fix(i18n-utils): guard globalThis.process access in languageDetector for edge runtimes - #8751
Merged
zllkjc merged 2 commits intoJul 29, 2026
Conversation
🦋 Changeset detectedLatest commit: 6525306 The changes in this PR will be included in the next version bump. This PR includes changesets to release 117 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zllkjc
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
languageDetectorreadprocess.envdirectly when deriving shell locale fallbacks. Edge runtimes such as Cloudflare Workers and Deno may not exposeprocess, so language detection could throw before reaching theIntlfallback.Fix
Read
process.envthrough an optionalglobalThis.processshape before applying the existingLC_ALL,LC_MESSAGES,LANG,LANGUAGE, andIntlfallback order. This keeps the detector's order unchanged while avoiding unguarded process access.Test
Added a unit test that deletes
globalThis.processand verifies detection falls back to a mockedIntllocale. Ran package install, build, unit tests, and Biome on the touched TypeScript files.🤖 Generated with Claude Code