Add WPT for Selection.modify('extend') in bidi text#60515
Merged
Conversation
Tests for Selection.modify('extend', direction, 'character') covering
logical (forward/backward) and visual (left/right) directions across
LTR, RTL, and mixed bidi text.
Tests to support the spec change PR -
w3c/selection-api#357
Bug: 521439529
Change-Id: I22003e7c98e347f7eb43c93697a7ed21ca025884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7912663
Reviewed-by: Pranav Modi <pranavmodi@microsoft.com>
Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1644418}
wpt-pr-bot
approved these changes
Jun 10, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
2073f39 to
b570a13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for Selection.modify('extend', direction, 'character') covering
logical (forward/backward) and visual (left/right) directions across
LTR, RTL, and mixed bidi text.
Tests to support the spec change PR -
w3c/selection-api#357
Bug: 521439529
Change-Id: I22003e7c98e347f7eb43c93697a7ed21ca025884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7912663
Reviewed-by: Pranav Modi <pranavmodi@microsoft.com>
Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1644418}