ci(rust): run clippy on the first-party Rust crates

[goosewobbler]

Description

Nothing in CI lints Rust today. The only Rust that gets compiled is the dioxus crates on Linux (_ci-build-dioxus-crates.reusable.yml) plus the fixture app builds — so tauri-plugin-webdriver's #[cfg]-gated platform modules are each seen by exactly one runner and never under lint, and packages/tauri-plugin is only ever compiled transitively.

The result is that violations accumulate on main unnoticed. Both open Tauri contributor PRs hit them and had to work around them with -A flags to get a clean local clippy run (#527 used -A clippy::incompatible-msrv; #532 fixed one of them as a drive-by). That's friction we're pushing onto contributors for no reason.

What this adds

_ci-rust-clippy.reusable.yml runs cargo clippy --all-targets -- -D warnings over a caller-supplied, newline-separated crate list, wired into ci.yml as:

Job	OS	Crates	Gate
clippy-tauri-crates-linux	ubuntu	tauri-plugin, tauri-plugin-webdriver	run_tauri
clippy-tauri-crates-windows	windows	same	run_tauri
clippy-tauri-crates-macos-arm	macOS	same	run_tauri
clippy-dioxus-crates-linux	ubuntu	dioxus-bridge, dioxus-driver, dioxus-embedded-driver	run_dioxus

The tauri crates run on all three OSes on purpose — a single-OS run would leave two of macos.rs / windows.rs / linux.rs unlinted, which is precisely how the current violations survived. Dioxus is Linux-only, matching the documented v1 scope of the existing build-dioxus-crates-linux job. Both are gated on the same detect-changes outputs as their sibling build jobs (packages/tauri-plugin* → tauri, packages/dioxus-* → dioxus, per the path classifier).

Violations fixed

Six, across three crates:

• executor.rs — cast_unsigned / cast_signed for cookie expiry. These are stable since 1.87 against the crate's declared rust-version = "1.77", so this was a genuine MSRV violation rather than lint noise. Switched to try_from.
• macos.rs — .to_string() on a Display type passed into format!.
• commands.rs (×2) — nested if folded into its match guard; map_or(false, …) → is_some_and(…) (stable since 1.70, matching that crate's MSRV).
• dioxus-bridge/invoke.rs — redundant |args| Ok(args) closure.

The commands.rs guard collapse is behaviour-preserving: when the added conditions fail the arm falls through to _ => {}, which is what the inner if did by falling out of the block.

Deliberately not included

cargo fmt --check. 18 files in tauri-plugin-webdriver alone already drift from rustfmt on main, so wiring it up needs a repo-wide reformat first — which would conflict with both open Tauri PRs. Worth doing as its own PR once those land.

Also not included: cargo test for the tauri plugin crates. Those 17 unit tests currently never run in CI either, and clippy --all-targets already pays the compile cost, so it's a cheap follow-up — happy to fold it in here if you'd prefer.

Type of Change

• Internal/tooling change (build scripts, CI, etc.)
• Bug fix (non-breaking change which fixes an issue)

Scope

• scope:tauri - Tauri service and plugin

Testing

Locally on macOS, all five crates pass the exact command CI runs:

packages/tauri-plugin                      PASS
packages/tauri-plugin-webdriver            PASS
packages/dioxus-bridge                     PASS
packages/dioxus-driver                     PASS
packages/dioxus-embedded-driver            PASS

• cargo test — tauri-plugin-webdriver 15 passed, dioxus-bridge 24 passed, tauri-plugin has no tests
• actionlint .github/workflows/*.yml — clean (the lint job runs this)
• Confirmed the four touched Rust files carry the same rustfmt drift before and after these edits, i.e. no new drift introduced

Only the macOS leg is verified locally. The Linux and Windows legs compile code paths I can't reach from here (linux.rs, windows.rs), so this PR's own CI run is the real check — don't merge until those three jobs are green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CsgeivZCqduTQmWK55zqiT

[github-actions]

Standing release PR: #456 · 15 packages queued · open 39d 11h 22m · ✅ ready to merge

Release Preview — 17 packages

Note: Labels on this PR are advisory in standing-pr mode. Bumps come from conventional commits in the standing PR; override by editing labels on the standing PR itself. Add release:immediate to bypass the standing PR and release this PR directly.

These changes will be added to the release PR (#456) when merged:

Changelog

@wdio/dioxus-bridge 1.0.0-next.3 → 1.0.0-next.4

Changed

• run clippy on the first-party Rust crates (rust)

@wdio/dioxus-service 1.0.0-next.3 → 1.0.0-next.4

Changed

• Update version to 1.0.0-next.4

wdio-dioxus-driver 1.0.0-next.3 → 1.0.0-next.4

Changed

• Update version to 1.0.0-next.4

wdio-dioxus-embedded-driver 1.0.0-next.3 → 1.0.0-next.4

Changed

• Update version to 1.0.0-next.4

@wdio/tauri-plugin 1.2.0 → 1.2.1

Changed

• run clippy on the first-party Rust crates (rust)

@wdio/tauri-service 1.2.0 → 1.2.1

Changed

• Update version to 1.2.1

tauri-plugin-wdio-webdriver 1.2.0 → 1.2.1

Changed

• run clippy on the first-party Rust crates (rust)

@wdio/flutter-service 1.0.0-next.1 → 1.0.0-next.2

Changed

• Update version to 1.0.0-next.2

wdio_flutter N/A → 0.1.1

Changed

• Update version to 0.1.1

@wdio/electrobun-service 0.1.0 → 0.1.1

Changed

• Update version to 0.1.1

@wdio/electron-service 10.1.0 → 10.1.1

Changed

• Update version to 10.1.1

@wdio/native-cdp-bridge 1.0.0 → 1.0.1

Changed

• Update version to 1.0.1

@wdio/native-core 1.0.0 → 1.0.1

Changed

• Update version to 1.0.1

@wdio/native-mobile-core 1.0.0 → 1.0.1

Changed

• Update version to 1.0.1

@wdio/native-spy 1.1.0 → 1.1.1

Changed

• Update version to 1.1.1

@wdio/native-types 2.4.0 → 2.4.1

Changed

• Update version to 2.4.1

@wdio/native-utils 2.5.0 → 2.5.1

Changed

• Update version to 2.5.1

@wdio/react-native-service 1.0.0-next.0 → 1.0.0-next.1

Changed

• Update version to 1.0.0-next.1

After merge — predicted release

No version escalation — this PR's changes will be included in the queued release without affecting the projected versions.

Package	Standing PR	This PR	After merge
@wdio/dioxus-bridge	1.0.0-next.4	1.0.0-next.4	1.0.0-next.4
@wdio/dioxus-service	1.0.0-next.4	1.0.0-next.4	1.0.0-next.4
@wdio/electrobun-service	0.2.0	0.1.1	0.2.0
@wdio/electron-service	10.2.0	10.1.1	10.2.0
@wdio/native-cdp-bridge	1.1.0	1.0.1	1.1.0
@wdio/native-core	1.1.0	1.0.1	1.1.0
@wdio/native-spy	1.2.0	1.1.1	1.2.0
@wdio/native-types	2.5.0	2.4.1	2.5.0
@wdio/native-utils	2.6.0	2.5.1	2.6.0
@wdio/tauri-plugin	1.3.0	1.2.1	1.3.0
@wdio/tauri-service	1.3.0	1.2.1	1.3.0
tauri-plugin-wdio-webdriver	1.3.0	1.2.1	1.3.0
wdio_flutter	0.2.0	0.1.1	0.2.0
wdio-dioxus-driver	1.0.0-next.4	1.0.0-next.4	1.0.0-next.4
wdio-dioxus-embedded-driver	1.0.0-next.4	1.0.0-next.4	1.0.0-next.4

---

Updated automatically by ReleaseKit

[greptile-apps]

Greptile Summary

The PR adds cross-platform Clippy checks for the first-party Tauri and Dioxus Rust crates and resolves the lint violations they expose.

• Adds a reusable workflow that runs Clippy with warnings denied.
• Runs platform-specific Tauri checks on Linux, Windows, and macOS, plus Dioxus checks on Linux.
• Adds all four Clippy jobs to the required CI status aggregator.
• Applies behavior-preserving Rust lint and MSRV compatibility fixes.

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported required-status bypass is fixed because all four Clippy jobs now feed into the CI status aggregator, which fails for failed or cancelled dependencies while accepting intentionally skipped jobs.

Important Files Changed

Filename	Overview
.github/workflows/_ci-rust-clippy.reusable.yml	Adds the reusable, multi-crate Clippy workflow with Linux dependency installation and aggregated crate failure handling.
.github/workflows/ci.yml	Wires platform-specific Clippy jobs into change detection and the required CI status aggregator, resolving the prior bypass.
packages/tauri-plugin-webdriver/src/platform/executor.rs	Replaces MSRV-incompatible integer casts with checked timestamp conversions.
packages/tauri-plugin/src/commands.rs	Applies behavior-preserving Clippy-driven simplifications to JavaScript parsing conditions.
packages/dioxus-bridge/src/invoke.rs	Simplifies a test handler closure without changing its result.
packages/tauri-plugin-webdriver/src/platform/macos.rs	Removes a redundant string allocation while formatting macOS errors.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Detect changed packages] --> B{Tauri changed?}
  A --> C{Dioxus changed?}
  B -->|Yes| D[Clippy: Linux]
  B -->|Yes| E[Clippy: Windows]
  B -->|Yes| F[Clippy: macOS ARM]
  C -->|Yes| G[Clippy: Linux]
  D --> H[CI status aggregator]
  E --> H
  F --> H
  G --> H
  H --> I[CI / Required]

Loading

_{Reviews (3): Last reviewed commit: "ci(rust): gate the required status on th..." | Re-trigger Greptile}