fix(ci): match the @wdio/utils tarball by pattern, drop the dead override - #583
Open
goosewobbler wants to merge 1 commit into
Open
fix(ci): match the @wdio/utils tarball by pattern, drop the dead override#583goosewobbler wants to merge 1 commit into
goosewobbler wants to merge 1 commit into
Conversation
…ride Three places named this tarball and none agreed: the electron-builder fixtures pinned 9.23.0 (#94), test-package.ts looked for 9.23.3 (#132), and update-packages.ts — the only thing that produces it — names it after whatever version it packed. No such file exists in the tree. The fixture pin was unreachable: test-package.ts strips every file: override out of the fixture config before building the sandbox, so it was read and discarded on every run. Remove it. The neighbouring minimatch override is a plain version and does apply, so it stays. The pinned lookup was reachable but guarded by existsSync, so a mismatch was a silent no-op: regenerate the tarball at any other version and the package tests go green having never exercised the patched build. Match by pattern instead, and fail loudly on more than one candidate rather than picking arbitrarily. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CsgeivZCqduTQmWK55zqiT
Contributor
Release Preview — no release
Updated automatically by ReleaseKit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three places named the
@wdio/utilstarball and none of them agreed:electron-builder-app-{cjs,esm}sandbox configwdio-utils-9.23.0.tgzscripts/test-package.tswdio-utils-9.23.3.tgzscripts/update-packages.ts— the only producer${packedFile}, fromnpm packThe producer names the file after whatever version it packed; both consumers pinned a version, and pinned different ones. #132 bumped one and left the other. No such tarball exists in the tree, and it isn't gitignored, so it isn't an expected build artifact either.
The fixture pin was unreachable
test-package.tsdiscards everyfile:override from the fixture config before assembling the sandbox:So that line was read and thrown away on every run since #94. Removed.
The
minimatch: 10.2.2override sitting next to it is a plain version, not afile:spec, so it is preserved and applied — it stays.The pinned lookup failed silently
That one is reachable, but guarded by
existsSync. Pack a patched@wdio/utilsviaupdate-packages.tsat any version other than exactly9.23.3and the guard misses, the override is skipped without a word, and the package tests go green having never exercised the build you just made. A silent no-op, which is the worse failure mode — you'd trust the result.Now matched by pattern, so a regenerated tarball is picked up at any version. More than one candidate throws rather than picking arbitrarily.
Verification
Exercised all three paths:
electron-builder-app-cjspackage test passes end to end.wdio-utils-99.0.0.tgz): matched by the new pattern — and confirmed the old9.23.3pin would not have matched it. This is precisely the bug.format:checkandlintclean.Also updates the cache-safety comment in
setup-workspace/action.yml, whose reasoning was written around the fixture override that this PR deletes. The conclusion is unchanged — the root lockfile still never references the tarball — but it now points attest-package.ts, which is where the override actually comes from.