chore: remove agent-os (salvage architecture docs + ADRs first) - #586
Open
goosewobbler wants to merge 2 commits into
Open
chore: remove agent-os (salvage architecture docs + ADRs first)#586goosewobbler wants to merge 2 commits into
goosewobbler wants to merge 2 commits into
Conversation
…ent-os Preparing to remove agent-os (its spec-first workflow solves a problem we no longer have). This commit rescues the parts worth keeping before the deletion. - Move the 14 project-specific architecture notes from agent-os/standards/global/ to docs/architecture/ (they describe this codebase, not agent-os), with a README index. - Move the two forward-looking specs to docs/design/: the ROADMAP-linked mobile-service-convergence design and the on-hold electrobun multi-instance upstream-issue draft. These describe unbuilt work, so the code is not yet the spec. - Add three ADRs distilled from the historical specs before they go: 0002 (Tauri defaults to an in-app embedded WebDriver server), 0003 (copy the reference service; extract shared code only on the Rule of Three — the built-then-deleted native-utils base-class story), 0004 (Electrobun is driven over CDP; the default WebKit renderer is unsupported). - Repoint every reference into the moved/deleted content: AGENTS.md, ROADMAP.md, the electrobun mock.ts comment, and the add-native-service skill now point at docs/; the electrobun "Framework gaps" plan comments (which referenced a since-deleted plan) now cite the #320 CEF umbrella issue; drop the agent-os ignore glob / doc examples in eslint.config.js and detect-changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CKc4JHZKXfyqCiiU4C2b7V
Agent OS's spec-first scaffolding was designed to micromanage agentic workflows with spec-first guardrails — a problem this project no longer has (and one its own author now considers obsolete). The parts worth keeping were salvaged in the previous commit (docs/architecture, docs/design, ADRs). Removed: - agent-os/ entirely: config.yml, product/mission.md (superseded by README/ROADMAP), the generic backend/frontend/testing standards boilerplate, and the historical specs (the code is the spec for what shipped; ADRs capture the decisions). - .claude/commands/agent-os/ (9 workflow commands) and .claude/agents/agent-os/ (8 spec/implementation subagents). - 15 standards-wrapper skills: the backend-*/frontend-*/testing-* boilerplate and the 6 global-* skills (which linked to standards files that never existed). Kept: the add-native-service skill (project-specific, independent of the spec-first workflow). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CKc4JHZKXfyqCiiU4C2b7V
Contributor
|
Too many files changed for review. ( Bypass the limit by tagging |
Contributor
Release Preview — no release
Updated automatically by ReleaseKit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agent OS's spec-first scaffolding was built to micromanage agentic workflows with spec-first guardrails — a problem this project no longer has (and one its own author now considers obsolete). This removes it, keeping the parts that carry lasting value.
What this does
Two commits, salvage-then-remove:
1. Salvage the keepers (
docs: salvage …)docs/architecture/— the 14 project-specific standards fromagent-os/standards/global/(mock architecture, service split, driver lifecycle, binary discovery…) that describe this codebase, with a README index.docs/design/—mobile-service-convergence.md(linked from ROADMAP; describes unbuilt work) and the on-holdelectrobun-multi-instance-upstream-draft.md.0002— Tauri defaults to an in-app embedded WebDriver server (macOS without a subscription; CrabNebula/external weighed and rejected).0003— copy the reference service; extract shared code only on the Rule of Three (the built-then-deletednative-utilsbase-class story).0004— Electrobun is driven over CDP; the default WebKit renderer is unsupported.AGENTS.md,ROADMAP.md, the electrobunmock.tscomment, and the keptadd-native-serviceskill now point atdocs/. The 9 electrobun "Framework gaps" comments (which cited a since-deleted plan) now cite the Electrobun: track upstream CEF fixes (Linux/Windows, multiremote, multi-window, deeplink) #320 CEF umbrella issue. Dropped theagent-osignore-glob / doc examples ineslint.config.jsanddetect-changes.2. Remove agent-os (
chore: remove agent-os …)agent-os/(config,product/mission.md, the generic backend/frontend/testing standards boilerplate, and the historical specs — the code is the spec for what shipped; ADRs capture the decisions)..claude/commands/agent-os/(9 workflow commands) and.claude/agents/agent-os/(8 spec/implementation subagents).backend-*/frontend-*/testing-*boilerplate and the 6global-*skills (which linked to standards files that never existed).Kept: the
add-native-serviceskill (project-specific, independent of the spec-first workflow).Notes for review
git grep -i agent-osis now zero across the tree.+213 / −20,214— almost entirely the deleted specs, boilerplate standards, and workflow command/agent definitions.gitdetects them as renames); the ADRs are the only new prose.🤖 Generated with Claude Code
https://claude.ai/code/session_01CKc4JHZKXfyqCiiU4C2b7V