Skip to content

fix(app): keep test-tree and action rows on one line inside their panel - #270

Merged
vishnuv688 merged 2 commits into
mainfrom
vv/ui-layout-polish
Aug 3, 2026
Merged

fix(app): keep test-tree and action rows on one line inside their panel#270
vishnuv688 merged 2 commits into
mainfrom
vv/ui-layout-polish

Conversation

@vishnuv688

@vishnuv688 vishnuv688 commented Aug 3, 2026

Copy link
Copy Markdown
Member

What & why

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Polish (an improvement to an existing feature)
  • Breaking change (existing behavior changes for users)
  • Documentation
  • Internal (build, CI, dependencies, tooling)

Packages touched

  • shared (types and contracts)
  • core (framework-agnostic capture/reporting)
  • elements (published element/snapshot API — @wdio/elements)
  • service (WebdriverIO adapter)
  • nightwatch-devtools (Nightwatch adapter)
  • selenium-devtools (Selenium adapter)
  • backend (server)
  • app (UI)
  • script (page-injected runtime)

Notes for reviewers

Screenshots / recordings

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Greptile Summary

The PR keeps sidebar test names and workbench action labels on one line by default while allowing one clicked row to reveal its full text.

  • Adds constrained flex sizing, clipping, ellipsis, and click-controlled label wrapping.
  • Moves reveal ownership to the explorer and actions panel so only one row is expanded at a time.
  • Uses keyed Lit rendering to preserve each action row’s identity as groups expand and collapse.
  • Adds UI and unit coverage for reveal behavior and row keys.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported row-state reuse is addressed through parent-owned reveal identity and keyed action-row rendering.

Important Files Changed

Filename Overview
packages/app/src/components/workbench/action-tree.ts Adds namespaced, stable identities for keyed action-tree rendering.
packages/app/src/components/workbench/actions.ts Centralizes reveal state and keys action rows so expansion changes do not transfer row state.
packages/app/src/components/workbench/actionItems/item.ts Adds controlled reveal properties and shared single-line label styling.
packages/app/src/components/sidebar/explorer.ts Owns test-row reveal state independently from automatic selection.
packages/app/src/components/sidebar/test-suite.ts Constrains test labels to one line and wraps only the explicitly revealed row.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Click[User clicks row] --> Event[Row emits reveal request]
  Event --> Owner[Explorer or actions panel updates revealed identity]
  Owner --> Render[Keyed render updates rows]
  Render --> Open[Clicked label wraps]
  Render --> Fold[Other labels remain single-line]
Loading

Reviews (2): Last reviewed commit: "fix(app): reflow one row at a time in th..." | Re-trigger Greptile

Comment thread packages/app/src/components/workbench/actionItems/item.ts
@vishnuv688
vishnuv688 merged commit a646fdc into main Aug 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant