Open
Conversation
|
@dgca is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ERC-8021 Schema 2 (CBOR-encoded) attribution support to the
Attributionmodule. This enables extensible transaction annotation with optional fields for app codes, wallet codes, custom registries, and arbitrary metadata.Design choices that could use a second look:
appCode,walletCode,registries,metadata) rather than the single-letter CBOR keys (a,w,r,m) from the spec. I decided to use "registries" instead of "codeRegistries" (which would align with schema 1'scodeRegistryfield) so the field names match the single-letter CBOR fields.AttributionSchemaId2Registrytype even though it's the same asAttributionSchemaId1Registryto avoid confusion (e.g.SchemaId2field usingSchemaId1type).Example usage: