Defer updating the reused window's associated document until activation#12421
Draft
shannonbooth wants to merge 1 commit into
Draft
Defer updating the reused window's associated document until activation#12421shannonbooth wants to merge 1 commit into
shannonbooth wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion purposes, this is the fix for #12415 mentioned in that issue. It is as far as I can tell is correct by deferring setting the associated document until activation.
I'm not sure of what approach would have the best model here. Maybe instead there needs to be a more explicit distinction here between the Window's associated Document and the browsing context's currently active Document during this transient state (maybe window needs a "current" document?).
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )