Conversation
ibdknox
requested changes
Feb 7, 2017
src/runtime/dsl.ts
Outdated
| record.__output = true; | ||
| this.__block.records.push(record); | ||
|
|
||
| if(typeof attributeName === "string") { |
Contributor
There was a problem hiding this comment.
add should not be added to the identity, so it's always dynamic
| blocks:DSLBlock[] = []; | ||
| runtimeBlocks:runtime.Block[] = []; | ||
| index:indexes.Index; | ||
| nodeCount = 0; |
Contributor
Author
There was a problem hiding this comment.
J/k, this tracks the nodeIds now that they aren't all awesome nodes.
src/runtime/dsl.ts
Outdated
| block(name:string, func:(block:DSLBlock) => any) { | ||
| let block = new DSLBlock(name, func, this); | ||
| block(name:string, func:BlockFunction) { | ||
| let block = new DSLBlock(name, func, this, undefined, undefined); |
Contributor
There was a problem hiding this comment.
don't need the undefineds here now
src/runtime/dsl.ts
Outdated
| } | ||
| trans.exec(this.index); | ||
| console.log(trans.changes.map((change, ix) => ` <- ${change}`).join("\n")); | ||
| // console.log(trans.changes.map((change, ix) => ` <- ${change}`).join("\n")); |
Contributor
There was a problem hiding this comment.
we should make this console.info
src/runtime/runtime.ts
Outdated
| } | ||
|
|
||
| export function maybeReverse(value?:ID):ID|RawValue|undefined { | ||
| if(!value) return undefined; |
Contributor
There was a problem hiding this comment.
this should be return value
src/watchers/html.ts
Outdated
| instance.__styles!.splice(ix, 1); | ||
|
|
||
| for(let otherStyleId of instance.__styles!) { | ||
| console.log("reapplying", otherStyleId); |
src/watchers/html.ts
Outdated
| } | ||
|
|
||
| insertChild(parent:Instance, child:Instance) { | ||
| parent.appendChild(child); |
| return [ | ||
| style.add(attribute, value) | ||
| ]; | ||
| }) |
Contributor
There was a problem hiding this comment.
we can probably collapse the block and watch here
|
Is it related to this rfc ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.