Skip to content

feat(lightdash) add lightdash - #2601

Open
kiliantscherny wants to merge 4 commits into
withfig:masterfrom
kiliantscherny:lightdash-completion-spec
Open

feat(lightdash) add lightdash#2601
kiliantscherny wants to merge 4 commits into
withfig:masterfrom
kiliantscherny:lightdash-completion-spec

Conversation

@kiliantscherny

Copy link
Copy Markdown

Created specs for Lightdash

@withfig-bot

withfig-bot commented May 1, 2025

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@withfig-bot

Copy link
Copy Markdown
Contributor

Overview

src/lightdash.ts:

Info:

@withfig-bot

Copy link
Copy Markdown
Contributor

Hello @kiliantscherny,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@kiliantscherny

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request May 1, 2025

@ZeRego ZeRego left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@chaynabors

Copy link
Copy Markdown
Member

@kiliantscherny Can you fix formatting lints?

@kiliantscherny

kiliantscherny commented May 21, 2025

Copy link
Copy Markdown
Author

@chaynabors just fixed them now 👍

When I run pnpm lint locally I'm getting these errors:

❯ pnpm lint

> @withfig/autocomplete@2.692.2 lint /Users/kiliantscherny/Documents/Development/Personal/autocomplete
> eslint '**/*.ts' && npx prettier --check '**/*.ts' --parser typescript


/Users/kiliantscherny/Documents/Development/Personal/autocomplete/build/dynamic/index.d.ts
  3:18  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any

✖ 1 problem (1 error, 0 warnings)

 ELIFECYCLE  Command failed with exit code 1.

Not sure if that's going to be an issue nor how to resolve it

@kiliantscherny
kiliantscherny requested a review from chaynabors May 28, 2025 08:12
@kiliantscherny

Copy link
Copy Markdown
Author

Hi @chaynabors @mschrage would I be able to get your review on this when you get the chance? Thanks!

@kiliantscherny

Copy link
Copy Markdown
Author

Hey @chaynabors @mschrage is this good to get merged? Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants