perf: vectorize corner shaders - #178
Open
WillPower3309 wants to merge 5 commits into
Open
Conversation
WillPower3309
marked this pull request as draft
March 14, 2026 03:37
Member
Author
|
having some weird graphical issues right now, missing something |
Member
Author
|
@ErikReider Can I ask you a huge favor? I'm really curious on how this compares to the current solution as far as tracy is considered. Would you mind checking for me? |
WillPower3309
marked this pull request as ready for review
March 16, 2026 22:15
ErikReider
requested changes
May 21, 2026
Comment on lines
+1
to
+2
| // TODO: remove relative pos - can do this via vertex shader | ||
| // we can then do vx and vy precomputed + on the vertex shader |
Member
There was a problem hiding this comment.
This should in theory also help with the float16 issues on Nvidia if I'm not mistaken
| // we can then do vx and vy precomputed + on the vertex shader | ||
|
|
||
| vec2 relative_pos = (gl_FragCoord.xy - position); | ||
| // radii is vec4(radius_tr, radius_br, radius_tl, radius_bl) |
Member
There was a problem hiding this comment.
Just curious, but is there a reason for this radius "winding order"?
| } | ||
| return 1.0; | ||
| } | ||
| vec4 dists = sqrt(x_max*x_max + y_max*y_max) + min(max(vx, vy), 0.0) - radii; |
Member
There was a problem hiding this comment.
I wonder if caching these in a LUT would help?
Comment on lines
-813
to
+870
| glTexParameteri(texture->target, GL_TEXTURE_MAG_FILTER, GL_LINEAR); | ||
| glTexParameteri(texture->target, GL_TEXTURE_MAG_FILTER, GL_LINEAR); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on my tinkering in https://www.shadertoy.com/view/sfs3DX