Skip to content

Added bignum module based on the fantastic bigz library.#98

Closed
denise-amiga wants to merge 1 commit into
wonkey-coders:developfrom
denise-amiga:add_bigz_module
Closed

Added bignum module based on the fantastic bigz library.#98
denise-amiga wants to merge 1 commit into
wonkey-coders:developfrom
denise-amiga:add_bigz_module

Conversation

@denise-amiga
Copy link
Copy Markdown
Contributor

No description provided.

@seyhajin
Copy link
Copy Markdown
Contributor

seyhajin commented Apr 7, 2026

Thanks for your PR.
Does it only work on Linux?
Have you tested it on other platforms?

@denise-amiga
Copy link
Copy Markdown
Contributor Author

denise-amiga commented Apr 7, 2026

I only have Linux, but I don't think there will be any problems compiling it on other platforms since the library is in C (not C++).
The only potential issue is the absence of a specific include/type on a particular platform.
Since I'm currently only a Linux user, I'm unfamiliar with other platforms, sorry.
I used that same library in BlitzMax for Windows before without any problems (without changing anything at all). I'm new to Wonkey, and to do the binding, I used the SDL module as a template (which is cross-platform, but much more complex). Since I noticed that the makefiles_"plataform".wx files weren't exactly the same, I only created the one I could test.
It's true I uploaded it too quickly, before it was finished; I apologize.

But I don't think there will be any problem making it cross-platform, finishing the Rational part (which I haven't included because I didn't need it for a project I'm currently working on), and adding the documentation to make it "perfect."
Any help is welcome :)

Comment on lines +4 to +7
#Import "native/bign.c"
#Import "native/bigq.c"
#Import "native/bigz.c"
#Import "native/bzf.c"
Copy link
Copy Markdown
Contributor

@seyhajin seyhajin Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move this code directly into the bigz.wx, delete makefile.wx and makefile_linux.wx files and commit/push this change.

This will restart the CI, and we can check whether the module compiles on other platforms before merging it.

@denise-amiga denise-amiga closed this by deleting the head repository Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants