Skip to content

compose: Fix two leaks #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ximion merged 2 commits into from
May 27, 2026
Merged

compose: Fix two leaks #752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84cdb03
compose: Unref icon_policy in asc_compose_finalize
bbhtt May 27, 2026
7f8716a
compose: Free array from asc_result_get_component_ids_with_hints
bbhtt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compose/asc-compose.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ asc_compose_finalize (GObject *object)
if (priv->locale_unit != NULL)
g_object_unref (priv->locale_unit);

g_object_unref (priv->icon_policy);

g_mutex_clear (&priv->mutex);

G_OBJECT_CLASS (asc_compose_parent_class)->finalize (object);
Expand Down Expand Up @@ -1755,7 +1757,7 @@ asc_compose_process_task_cb (AscComposeTask *ctask, AscCompose *compose)
/* clean up superfluous hints in case we were filtering the results, as some rejected
* components may have generated errors while we were inspecting them */
if (filter_cpts) {
const gchar **cids = asc_result_get_component_ids_with_hints (ctask->result);
g_autofree const gchar **cids = asc_result_get_component_ids_with_hints (ctask->result);
for (guint i = 0; cids[i] != NULL; i++) {
if (!g_hash_table_contains (priv->allowed_cids, cids[i])) {
/* we want to catch out-of-scope XML errors as well, which have a CID
Expand Down
Loading