fix: include user-defined LLM families in _resolve_architectures#4860
fix: include user-defined LLM families in _resolve_architectures#4860Ricardo-M-L wants to merge 1 commit into
Conversation
|
There is conflict, could you resolve it? |
58e9533 to
80b4f50
Compare
|
Tests cannot pass, I think you need to check why the tests failed. |
80b4f50 to
e02b207
Compare
|
Rebased onto latest |
|
FAILED xinference/core/tests/test_restful_api.py::test_restful_api - Failed: Timeout (>3000.0s) from pytest-timeout. Tests failed, and I think they are related to this PR. |
|
Polite bump 🙏 — to clarify the CI status here: all 10 reported failures are `pytest-timeout` hits on `test_restful_api` and `test_cmdline_of_custom_model` (>3000s), not actual assertion failures from this patch. These two tests are the same ones that have been timing out across many recent PRs (e.g. they timed out on green-merging PRs around the same window) and don't touch the `_resolve_architectures` code path this PR modifies — the OCR test failures from earlier runs are addressed in #4872. A re-run should clear them. Happy to rebase onto current main if you'd like. Summary of the fix: when `register_llm()` registers a user-defined family, that family wasn't surfaced in `_resolve_architectures()`, so a subsequent `launch` would fall back to the hardcoded built-in mapping and either fail or pick the wrong architecture. The PR adds the user-registered families to the lookup with the same precedence rules. |
|
Rerun still failed, I tried before, this is definitely related to your modification. |
|
@qinxuye gentle bump — this one was approved 2 weeks ago and has been |
|
Hi team, just following up on this PR. Happy to make any changes or address feedback if needed. Thanks for considering it! |
|
Tests failed, you need to fix it. https://github.com/xorbitsai/inference/actions/runs/25417269775/job/74551348182?pr=4860 |
|
Friendly nudge — this has your approval. The red check is the heavyweight |
|
Tried before, the failed tasks are caused by your code. |
The _resolve_architectures method only looked up architectures from BUILTIN_LLM_FAMILIES, which caused custom-registered models with a model_family pointing to a user-defined model to fail architecture resolution. Now combines both builtin and user-defined families. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
e02b207 to
49dfd71
Compare
Summary
Include user-defined LLM families in _resolve_architectures to ensure custom model families are properly recognized.
🤖 Generated with Claude Code