Replace last usage of LazyFrames#550
Open
g0djan wants to merge 1 commit intoyandexdataschool:masterfrom
Open
Conversation
It was replaced with this class everywhere else in this PR yandexdataschool#544
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
g0djan
commented
Oct 10, 2025
| "An observation is a 4-frame-stack of grayscale images with reduced resolution.\\\n", | ||
| "Memory (RAM) is a high-demand resource in this task. That's why:\n", | ||
| "1. We use the uint8 dtype instead of float32 the neural network will operate on\n", | ||
| "2. We don't represent them as numpy.ndarrays. **LazyFrames** are used by gym.wrappers.FrameStack instead. 2 consecutive observations share 3 of 4 frames. LazyFrames make use of this fact to save memory.\n", |
Contributor
Author
There was a problem hiding this comment.
LazyFrames are however still referenced in the explanation. I'd apreciate some advice on how this text should be updated accordingly
Collaborator
|
@zshrav |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was replaced with this class everywhere else in this PR #544