test(java): run integration test on PR with fine-grained benchmark timers - #4
Open
yangyzs wants to merge 7 commits into
Open
test(java): run integration test on PR with fine-grained benchmark timers#4yangyzs wants to merge 7 commits into
yangyzs wants to merge 7 commits into
Conversation
…guration" (googleapis#7288) Reverts googleapis#7274 Fixes googleapis#7287
… io error (googleapis#7291) Update the bidirectional streaming transport template to construct a std::io::Error with std::io::ErrorKind::BrokenPipe when sending over a closed request channel fails. This provides standard I/O broken pipe semantics to callers while preserving the error kind and message. For googleapis#6835
Run `librarian install` in rust integration. Fixes googleapis#7289
The convert-prost template skips fields of type `wkt::Any`, as these cannot be converted.
…ing (googleapis#7273) Extract request routing parameters from the initial request message for bidirectional streaming RPCs and pass them to the underlying transport. For googleapis#6835
Sidekick emits warnings when it runs into a comment that it does not know how to handle. The idea is to review if the comments need to be captured for the generated code. That was hard to design from first principles, without an example around. Finally we found an example for reserved enum value ranges: https://github.com/googleapis/googleapis/blob/37c83e244b70c6bfa1a527be976950226b2ee5b2/google/maps/weather/v1/precipitation.proto#L104-L105 There is nothing to emit for these comments, now we know and we can silence the warning.
…mers Instrument fine-grained benchmark timers in Java generation and enable integration test presubmit on PR for performance breakdown. TAG=agy CONV=b05fcd92-a581-401c-ada5-b4dbda65d62e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument fine-grained benchmark timers in Java generation and enable integration test presubmit on PR for performance breakdown.
TAG=agy
CONV=b05fcd92-a581-401c-ada5-b4dbda65d62e