Skip to content

Fix ".bin" not linked when preparing a git dependency#3723

Merged
bestander merged 1 commit into
yarnpkg:masterfrom
Volune:fix-bin-script-git-dependency
Jun 28, 2017
Merged

Fix ".bin" not linked when preparing a git dependency#3723
bestander merged 1 commit into
yarnpkg:masterfrom
Volune:fix-bin-script-git-dependency

Conversation

@Volune

@Volune Volune commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

Summary

Fix installation issue reported by @sammarks in #3553

  • I have package-a that depends on package-b (through a git URL as package-b is not published to a registry).
  • package-a and package-b both use Babel (listed in devDependencies in both).
  • package-b's prepare script is: babel --optional runtime src -d dist

When installing the dependencies of package-a, I get an error message: babel: command not found

Test plan

Improved test in __test__/fetchers.js (Updated test dependency Volune/test-js-git-repo@1958040 and Volune/test-js-git-repo@c455e0c)

@Volune Volune force-pushed the fix-bin-script-git-dependency branch from d54ee89 to ed280db Compare June 27, 2017 02:34
@bestander bestander merged commit 08c36fa into yarnpkg:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants