Add OpenTelemetry lib and metric-interfaces by maladetska · Pull Request #588 · ydb-platform/ydb-cpp-sdk

maladetska · 2026-02-07T12:58:13Z

No description provided.

maladetska · 2026-02-16T22:24:00Z

src/client/query/impl/query_spans.cpp

+void ParseEndpoint(const std::string& endpoint, std::string& host, int& port) {
+    auto pos = endpoint.find(':');
+    if (pos != std::string::npos) {
+        host = endpoint.substr(0, pos);
+        try {
+            port = std::stoi(endpoint.substr(pos + 1));
+        } catch (...) {
+            port = 2135;
+        }
+    } else {
+        host = endpoint;
+        port = 2135;
+    }
+}


это плохо, пока черновой вариант такой

maladetska · 2026-02-17T09:44:30Z

include/ydb-cpp-sdk/client/metrics/metrics.h

может быть, на файлы разбить?

github-actions · 2026-02-21T15:01:52Z

🌋 SLO Test Results

Status: 🟢 2 workloads tested • All passed

	Workload	Metrics	Regressions	Improvements	Links
🚀	table-gcc	8	0	2	Report • Check
🟢	table-clang	8	0	0	Report • Check

Generated by ydb-slo-action

cmake/external_libs.cmake

CMakeLists.txt

Gazizonoki

Мне кажется папка open_telemetry в корне не самая удобная штука. Это же плагин к sdk, может сделаем папку plugins(extensions или еще какое-то имя) и туда положим все такие штуки (экспортеры метрик, трейсов, логов для конкретных систем и т. д.)?

И с метриками, оно вообще используется по коду? SDK уже собирает много метрик, в задаче с метриками это и есть главная сложность, как аккуратно перевести все на общий интерфейс и выкинуть library/cpp/monlib уже к черту из внешнего репозитория (это так-то внутренняя штука, вылезла в open-source ydb-cpp-sdk из-за неаккуратности)

Gazizonoki · 2026-02-24T22:37:26Z

include/ydb-cpp-sdk/client/metrics/metrics.h

Как-то намешано все тут. И про метрики, и про спаны

Все еще надо разбить

include/ydb-cpp-sdk/client/metrics/metrics.h

Gazizonoki · 2026-02-24T22:46:48Z

open_telemetry/CMakeLists.txt

А может разделим? Тащить и метрики и трейсы сразу как-то странно, все же разные сущности. Вдруг трейсы пользователю не нужны?

Разделила, посмотри, пожалуйста

open_telemetry/src/otel.cpp

plugins/open_telemetry/src/metrics.cpp

src/client/query/impl/query_spans.cpp

src/client/query/client.cpp

Gazizonoki · 2026-03-10T18:34:29Z

include/ydb-cpp-sdk/client/driver/driver.h

+    //! Get configured metrics exporter implementation.
+    std::shared_ptr<NMetrics::IMetricRegistry> GetMetricExporter() const;
+
+    //! Get configured tracing exporter implementation.
+    std::shared_ptr<NMetrics::ITraceProvider> GetTraceExporter() const;


А зачем нам Get методы?

Gazizonoki · 2026-03-10T18:36:45Z

include/ydb-cpp-sdk/client/metrics/metrics.h

Все еще надо разбить

Gazizonoki · 2026-03-10T18:38:30Z

plugins/CMakeLists.txt

@@ -0,0 +1,3 @@
+if (YDB_SDK_ENABLE_OTEL_METRICS OR YDB_SDK_ENABLE_OTEL_TRACE)


Я думаю разделение должно быть прямо на уровне директорий (отдельные плагины). plugins/metrics/otel и plugins/trace/otel

Gazizonoki · 2026-03-10T18:40:57Z

src/client/impl/internal/grpc_connections/grpc_connections.h

+    std::shared_ptr<NMetrics::ITraceProvider> GetTraceExporter() const;
+
+    template<typename T>
+    T* GetExtensionApi() {


А это точно нужно?

Gazizonoki · 2026-03-10T18:44:09Z

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/extension.h

+
+namespace NYdb::inline V3::NMetrics {
+
+inline void AddOpenTelemetry(TDriverConfig& config


А зачем эта функция? Нам может быть полезно все сразу подключать?

Gazizonoki · 2026-03-10T18:50:40Z

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/metrics.h

+
+namespace NYdb::inline V3::NMetrics {
+
+class TOtelMetricRegistry : public IMetricRegistry {


Gazizonoki · 2026-03-10T18:52:20Z

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/metrics.h

+    opentelemetry::nostd::shared_ptr<opentelemetry::metrics::MeterProvider> MeterProvider_;
+    opentelemetry::nostd::shared_ptr<opentelemetry::metrics::Meter> Meter_;
+    std::mutex HistogramViewsLock_;
+    std::unordered_set<std::string> HistogramViews_;


Это дело бы неплохо за pimpl спрятать, чтобы в хедере не было инклюда на opentelemetry/metrics/...

Gazizonoki · 2026-03-10T18:52:46Z

plugins/open_telemetry/include/ydb-cpp-sdk/open_telemetry/trace.h

+    std::shared_ptr<ITracer> GetTracer(const std::string& name) override;
+
+private:
+    opentelemetry::nostd::shared_ptr<opentelemetry::trace::TracerProvider> TracerProvider_;


Gazizonoki · 2026-03-10T18:56:30Z

src/client/query/impl/query_spans.cpp

+void SafeLogSpanError(const char* message) noexcept {
+    try {
+        try {
+            Cerr << "TQuerySpan: " << message << ": " << CurrentExceptionMessage() << Endl;


Suggested change

Cerr << "TQuerySpan: " << message << ": " << CurrentExceptionMessage() << Endl;

std::cerr << "TQuerySpan: " << message << ": " << CurrentExceptionMessage() << std::endl;

Gazizonoki · 2026-03-10T18:56:36Z

src/client/query/impl/query_spans.cpp

+            return;
+        } catch (...) {
+        }
+        Cerr << "TQuerySpan: " << message << ": (unknown)" << Endl;


KirillKurdyukov requested a review from Gazizonoki February 9, 2026 12:04

maladetska commented Feb 16, 2026

View reviewed changes

maladetska commented Feb 17, 2026

View reviewed changes

init commit

a102d53

maladetska force-pushed the METRICS-0 branch from beec910 to a102d53 Compare February 17, 2026 10:43

.

9011838

make metrics as client_component

bbc803b

maladetska changed the title ~~init?~~ Add OpenTelemetry lib Feb 24, 2026

maladetska commented Feb 24, 2026

View reviewed changes

cmake/external_libs.cmake Outdated Show resolved Hide resolved

maladetska commented Feb 24, 2026

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

maladetska changed the title ~~Add OpenTelemetry lib~~ Add OpenTelemetry lib and metric-interfaces Feb 24, 2026

Gazizonoki requested changes Feb 24, 2026

View reviewed changes

maladetska added 2 commits March 1, 2026 02:20

fixes

feb3e8d

add includes

0e31bc1

Gazizonoki reviewed Mar 10, 2026

View reviewed changes

		@@ -0,0 +1,3 @@
		if (YDB_SDK_ENABLE_OTEL_METRICS OR YDB_SDK_ENABLE_OTEL_TRACE)


		namespace NYdb::inline V3::NMetrics {

		inline void AddOpenTelemetry(TDriverConfig& config


		namespace NYdb::inline V3::NMetrics {

		class TOtelMetricRegistry : public IMetricRegistry {

	Cerr << "TQuerySpan: " << message << ": " << CurrentExceptionMessage() << Endl;
	std::cerr << "TQuerySpan: " << message << ": " << CurrentExceptionMessage() << std::endl;

Conversation

maladetska commented Feb 7, 2026

Uh oh!

maladetska Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌋 SLO Test Results

Uh oh!

Uh oh!

Uh oh!

Gazizonoki left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maladetska Feb 16, 2026 •

edited

Loading

github-actions bot commented Feb 21, 2026 •

edited

Loading