Add tests to kill escaped mutants (#529)#545
Open
dbuhonov wants to merge 80 commits intoyiisoft:masterfrom
Open
Add tests to kill escaped mutants (#529)#545dbuhonov wants to merge 80 commits intoyiisoft:masterfrom
dbuhonov wants to merge 80 commits intoyiisoft:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
============================================
- Coverage 99.69% 99.63% -0.07%
Complexity 663 663
============================================
Files 43 43
Lines 1646 1622 -24
============================================
- Hits 1641 1616 -25
- Misses 5 6 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbuhonov
force-pushed
the
feature/529-mutant-part-1
branch
from
ec926d0 to
27f1743
Compare
… in EventsTraitTest.
…multiple test files.
…nd `RelationPopulator`
… behavior in RelationPopulator
…esFromPropertyNames
Tigrov
requested changes
May 2, 2026
Tigrov
approved these changes
May 6, 2026
Member
Tigrov
left a comment
Tigrov
left a comment
There was a problem hiding this comment.
Could you merge changes from master?
Author
Yes, I just resolve conflicts) |
…t-part-1 # Conflicts: # tests/ActiveQueryTest.php # tests/ActiveRecordTest.php # tests/EventsTraitTest.php
…te test `testJoinWithViaTableDoesNotDuplicateChildWhere`.
Author
|
@Tigrov Fixed the conflict. The checks that failed are not my fault. |
vjik
reviewed
May 7, 2026
Member
vjik
left a comment
vjik
left a comment
There was a problem hiding this comment.
Run cs-fixer and rector locally:
./vendor/bin/rector
./vendor/bin/php-cs-fixer fix| public function testRemoveDuplicatedRowsChecksPrimaryKeyPresenceInFirstRow(): void | ||
| { | ||
| $query = Customer::query(); | ||
| $method = new ReflectionMethod(ActiveQuery::class, 'removeDuplicatedRows'); |
Member
There was a problem hiding this comment.
Can we test it without reflection usage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covered Code MSI: 98%