Skip to content

Add first-class Ollama preset#40

Merged
yuanhao merged 1 commit into
mainfrom
fix/issue-37-ollama-tool-result-compat
May 26, 2026
Merged

Add first-class Ollama preset#40
yuanhao merged 1 commit into
mainfrom
fix/issue-37-ollama-tool-result-compat

Conversation

@yuanhao

@yuanhao yuanhao commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Closes #37.

Summary

  • Add first-class ModelConfig::ollama(base_url, model_id) support.
  • Honor OpenAiCompat::requires_assistant_after_tool_result when serializing OpenAI-compatible tool result runs.
  • Keep ModelConfig::local(...) neutral for LM Studio, llama.cpp, vLLM, and other compatible servers.
  • Document Ollama alongside the other first-class model presets.

Compatibility

  • Existing serialized OpenAiCompat configs remain compatible because the new flag defaults to false during deserialization.
  • Existing local OpenAI-compatible behavior is unchanged unless callers opt into the Ollama preset or flag.

Validation

  • cargo fmt --check
  • cargo test provider::model
  • cargo test

@yuanhao yuanhao merged commit 24747af into main May 26, 2026
1 check passed
@yuanhao yuanhao deleted the fix/issue-37-ollama-tool-result-compat branch May 26, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add first-class Ollama preset and honor assistant-after-tool-result compat

1 participant