I've reviewed the test results and made some improvements to branch c… #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overage across IPv4, IPv6, and the main library.
This commit introduces new unit tests to cover previously unasserted conditional branches in the IP address lookup logic.
Key improvements:
- IPv4:
- I added tests for `search()` and `searchLong()` when a valid IPv4
is not found in the database ranges (expecting null, though the current DB
has a catch-all).
- I also added a test for successful instantiation with an absolute DB path.
- IPv6:
- I added tests for `parseResult()` to handle IPv4-style results when
`this.ipv4` instance is not available (expecting null).
- I also added tests for specific edge cases in city string parsing logic
within `parseResult()`.
- Main Library (index.ts):
- I added tests for `searchRaw()` to explicitly verify null output
for invalid IP strings with both `parse=true` and `parse=false`.
These changes increase the robustness of the test suite and ensure more code paths are verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…overage across IPv4, IPv6, and the main library.
This commit introduces new unit tests to cover previously unasserted conditional branches in the IP address lookup logic.
Key improvements:
search()andsearchLong()when a valid IPv4 is not found in the database ranges (expecting null, though the current DB has a catch-all).parseResult()to handle IPv4-style results whenthis.ipv4instance is not available (expecting null).parseResult().searchRaw()to explicitly verify null output for invalid IP strings with bothparse=trueandparse=false.These changes increase the robustness of the test suite and ensure more code paths are verified.