Allow configuration of default properties of blosc compressor#6
Merged
joshmoore merged 3 commits intozarr-developers:mainfrom Jun 14, 2023
Merged
Conversation
Member
Author
|
Thanks again for this, @pedson. Merging for 0.4.0 but two things occur to me:
Those two taken together might balance each other out. 😄 Before this becomes too ingrained, it could likely use some more discussion (e.g. add interface methods for modifying, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally opened as bcdev#42
The goal of this PR is to allow the user to set the number of threads used for blosc decompression on the auto-created Compressor objects during read operations.
This is done via CompressorFactory.BloscCompressor.defaultProperties.put("nthreads", 8);
This was the least invasive/modifying approach I could find (in conjunction with PR bcdev#41 for user defined compressor objects). However, it does expose the actual BloscCompressor class and the implementation of the map. I'd be happy to implement something more extensive keeps the class implementation private if the maintainers prefer.
I also only updated the nthreads property to pull from the defaultProperties map rather than the default constants. If this approach is acceptable, I can change the other properties to have the same behavior.