-
-
Notifications
You must be signed in to change notification settings - Fork 370
Adding copy_store convenience method for Group
#3612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
melonora
wants to merge
25
commits into
zarr-developers:main
Choose a base branch
from
melonora:copy_store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+415
−4
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e3ee33b
add copy_store convenience method
melonora 83550a3
add synchronous call
melonora d473d6e
change comment, test not async
melonora bb1405e
fix test
melonora c62543a
support zarr v2
melonora cdbc2f7
remove use of _iter_chunk_regions
melonora e6e10df
change method name
melonora 9c42567
remove consolidate_metadata argument
melonora 63c652e
consolidate if consolidated
melonora d4924f5
add consolidated_metadata argument
melonora e83dda5
add docstring and argument
melonora 59b18ea
add support subgroup consolidated metadata
melonora b65d257
add argument to docstring
melonora 1056b9e
add example to docs groups
melonora eadb647
adjust docs
melonora 8c3471c
partial fix pre-commit
melonora 2cbb9b9
add to changes
melonora 128b924
change to call using self
melonora fa95e9c
obtain consolidated metadata from self
melonora 848811f
add test for matching parameters
melonora 3398325
implement path and add test
melonora ae205b5
Merge branch 'main' into copy_store
d-v-b 06ad2d7
add type hints
melonora 6b81a07
merge upstream changes
melonora 3e92ee9
remove unnecessary type ignore
melonora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Added the convenience method for `zarr.Group` to copy to a destination store which | ||
| can be of a different type than the original store of the `zarr.Group` to be | ||
| copied. This will also copy over the metadata as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.