Fix Swift label highlight captures#76
Open
ollieatkinson wants to merge 1 commit into
Open
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @ollieatkinson on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Swift Tree-sitter highlight captures so function parameter labels/names and call argument labels are not classified as
@property.This keeps themes from having to style Swift labels the same way as real member properties.
Fixes #74.
Test Case
The issue screenshots include this representative Swift code:
Expected captures after this change:
Before this change,
for,jobs,grouping, andbywere captured as@property.Validation
tree-sitter-cli queryagainst the screenshot-derived Swift snippet and comparedorigin/mainvs this branch.@propertyto@variable.parameter/@labelfor the issue cases.jobs.filterremains captured as@function.call.cargo test.git diff --check.