Skip to content

correcting little issue#3365

Closed
Divinedew wants to merge 1 commit into
zero-to-mastery:masterfrom
Divinedew:bouncingball
Closed

correcting little issue#3365
Divinedew wants to merge 1 commit into
zero-to-mastery:masterfrom
Divinedew:bouncingball

Conversation

@Divinedew
Copy link
Copy Markdown
Contributor

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

@github-actions
Copy link
Copy Markdown

Aloha @Divinedew 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • Overall feedback
    Reminder: the contribution should have 3 files in a folder in Art

    • Missing in 1 of the 1 contributions folders
      - please add the missing json file in the folder Art/Divinedew-Bouncingball
  • HTML feedback for Art/Divinedew-Bouncingball/index.html

    • Incorrect stylesheet link: update the href so it points to the correct CSS file

Happy Coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants