more sane backwards compatible filecache #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zesterer
requested changes
Nov 27, 2025
Owner
zesterer
left a comment
zesterer
left a comment
There was a problem hiding this comment.
I think this is a good addition. The only improvement I can imagine is to make the implementation of the old impl call out to the implementation of the new impl, removing the code duplication.
Contributor
Author
|
that improvement cant quite work because of lifetimes. the other way around works and i have added it. |
Owner
|
Thanks, that's just as good! It seems like it just needs a |
Contributor
Author
|
@zesterer fixed |
Owner
|
Thanks! |
Contributor
Author
|
@zesterer, so is there anything else left? Or is this just waiting for a feature window or something? |
Owner
|
No, I just fell asleep while CI was running 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so similar to the ideas in https://github.com/zesterer/ariadne/pull/99/files but without breaking any old code.
this version should just solve #40 with no down sides