docs: clarify custom font usage#367
Conversation
|
@dicnunz is attempting to deploy a commit to the shravan20's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughDocumentation is updated to explain the font query parameter usage, including case sensitivity, parameter composition, available bundled fonts, and contributor steps for adding new fonts. Changes span the main README and the dedicated fonts documentation file. ChangesFont Parameter Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 165-176: The README currently documents bundled fonts but does not
cover using a URL for custom fonts (the objective of issue `#119`); update the
README's font parameter section (the paragraph describing "font" and the
"Available Fonts" list) to include a short subsection showing how to provide a
remote font URL (example query param usage, expected URL format, and any
size/CORS constraints) plus one or two example image snapshots or links
demonstrating a custom-font URL in action, or if you do not want to add that
documentation now, remove the "Fixes `#119`" reference from the PR so the issue
remains open.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fdad1d7a-9110-44e0-af48-ecc5e4127c0b
📒 Files selected for processing (2)
README.mdsrc/fonts/README.md
|
The Vercel failures here are owner/team authorization gates for preview deploys, not docs-build failures from this patch. Local proof for the docs change: I checked |
|
Addressed the CodeRabbit docs gap on the latest push. What changed:
Validation:
I kept this docs-only and did not claim unsupported remote-font URL loading behavior. |
Summary
fontselects bundled font keys and that the keys are case-sensitivesrc/fonts/fonts.jsFixes #119.
Checks
nodedocs coverage check againstsrc/fonts/fonts.jsgit diff --checkOptional: if this saves you time and you want to settle it as a small paid docs microfix, $5 works here: https://nicdunz.gumroad.com/l/tiny-codex-teardown-direct
Summary by CodeRabbit