added the missing support for pipelines#29
Open
Oreboat wants to merge 3 commits into
Open
Conversation
|
Thanks for adding the pipeline bindings! I tested the PR and found an issue with the set_pipeline binding: extern fn ecs_set_pipeline(world: *world_t, pipeline: entity_t, delta_time: ftime_t) void; Should be extern fn ecs_set_pipeline(world: *world_t, pipeline: entity_t) void; https://github.com/SanderMertens/flecs/blob/master/include/flecs/addons/pipeline.h: |
Member
|
Thanks! I must have missed this PR somehow. Please fix the function and I'll merge it :) |
Member
|
Ping @Oreboat :) |
|
I have seen many people open PRs and then disappear, @Srekel . Maybe we should fix this ourselves. |
Author
|
apologies, I had not seen this until just now, I will fix it when I have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this in my own project, it does appear to work