Skip to content

fix: sparse SINDI build validation#1645

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
sparknack:codex/fix-sparse-sindi-build
May 27, 2026
Merged

fix: sparse SINDI build validation#1645
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
sparknack:codex/fix-sparse-sindi-build

Conversation

@sparknack

@sparknack sparknack commented May 26, 2026

Copy link
Copy Markdown
Collaborator

issue: #1555

  • Reject unsupported explicit sparse inverted_index_algo values during build
  • Fix empty SINDI index POSTING_LISTS section size accounting

@mergify

mergify Bot commented May 26, 2026

Copy link
Copy Markdown

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@sparknack sparknack force-pushed the codex/fix-sparse-sindi-build branch from cda6362 to eb9a2c9 Compare May 26, 2026 11:31
@sparknack sparknack changed the title Fix sparse SINDI build validation fix: sparse SINDI build validation May 26, 2026
Comment thread src/index/sparse/sparse_index_node.cc Outdated

Status
ValidateInvertedIndexAlgo(const SparseInvertedIndexConfig& cfg) const {
const auto algo = cfg.inverted_index_algo.value_or("");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sparknack should algo be converted to upper-case before the check?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The explicit inverted_index_algo is normalized to upper-case before validation, and CreateIndexImpl now uses the same normalized value when selecting/setting the build algorithm. I also changed the regression test to build a non-SINDI index with lower-case daat_maxscore so we cover both validation and actual index creation.

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

@sparknack looks good overall, waiting for the reply on comments

Signed-off-by: Shawn Wang <shawn.wang.ws@qq.com>
@sparknack sparknack force-pushed the codex/fix-sparse-sindi-build branch from eb9a2c9 to 2c41ae3 Compare May 27, 2026 03:30
@mergify mergify Bot added the ci-passed label May 27, 2026
@alexanderguzhva

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, sparknack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderguzhva

Copy link
Copy Markdown
Collaborator

/kind improvement
issue: #1555

@sre-ci-robot sre-ci-robot merged commit f868755 into zilliztech:main May 27, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants