fix: sparse SINDI build validation#1645
Conversation
|
@sparknack 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
cda6362 to
eb9a2c9
Compare
|
|
||
| Status | ||
| ValidateInvertedIndexAlgo(const SparseInvertedIndexConfig& cfg) const { | ||
| const auto algo = cfg.inverted_index_algo.value_or(""); |
There was a problem hiding this comment.
@sparknack should algo be converted to upper-case before the check?
There was a problem hiding this comment.
Done. The explicit inverted_index_algo is normalized to upper-case before validation, and CreateIndexImpl now uses the same normalized value when selecting/setting the build algorithm. I also changed the regression test to build a non-SINDI index with lower-case daat_maxscore so we cover both validation and actual index creation.
|
@sparknack looks good overall, waiting for the reply on comments |
Signed-off-by: Shawn Wang <shawn.wang.ws@qq.com>
eb9a2c9 to
2c41ae3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, sparknack The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind improvement |
issue: #1555