Skip to content

Fix SVS recall variability#1652

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
mihaic:fix-svs-recall-variability
May 28, 2026
Merged

Fix SVS recall variability#1652
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
mihaic:fix-svs-recall-variability

Conversation

@mihaic
Copy link
Copy Markdown
Contributor

@mihaic mihaic commented May 27, 2026

Use SVS nightly release with improves filtered search, fixing the root cause of recall variability.

Update fmt to match SVS.

Fix Conan SVS flag.

issue: #1654

@sre-ci-robot sre-ci-robot requested review from foxspy and liliu-z May 27, 2026 18:41
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

Welcome @mihaic! It looks like this is your first PR to zilliztech/knowhere 🎉

@mergify
Copy link
Copy Markdown

mergify Bot commented May 27, 2026

@mihaic 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@mihaic
Copy link
Copy Markdown
Contributor Author

mihaic commented May 27, 2026

@alexanderguzhva, I see unit test failures unrelated to the changes; the failures are caused by using alpha 1.2 with metric IP. Alpha should be unspecified in most cases so the appropriate default is used.

Use SVS nightly release with improves filtered search, fixing the root
cause of recall variability.

Update fmt to match SVS.

Fix Conan SVS flag.

Signed-off-by: Mihai Capotă <mihai@mihaic.ro>
@mihaic mihaic force-pushed the fix-svs-recall-variability branch from f4355dc to a4a318a Compare May 27, 2026 18:56
@foxspy
Copy link
Copy Markdown
Collaborator

foxspy commented May 28, 2026

issue: #1654

Copy link
Copy Markdown
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@foxspy
Copy link
Copy Markdown
Collaborator

foxspy commented May 28, 2026

/kind bugfix

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

@foxspy: The label(s) kind/bugfix cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind bugfix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@foxspy
Copy link
Copy Markdown
Collaborator

foxspy commented May 28, 2026

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label May 28, 2026
Copy link
Copy Markdown
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, mihaic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c1ce259 into zilliztech:main May 28, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants