Skip to content

fix: stop AISAQ async cache generation on teardown#1656

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:fix/aisaq-cache-stop
May 28, 2026
Merged

fix: stop AISAQ async cache generation on teardown#1656
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:fix/aisaq-cache-stop

Conversation

@foxspy
Copy link
Copy Markdown
Collaborator

@foxspy foxspy commented May 28, 2026

issue: #1655

Summary

  • Stop AISAQ async cache generation when the index state changes to STOPPING.
  • Align the async cache generation loop with the existing DiskANN stop-aware behavior to avoid teardown hangs.

Verification

  • pre-commit run --files thirdparty/DiskANN/src/pq_flash_aisaq_index.cpp
  • ./build-repro-asan/Release/tests/ut/knowhere_tests 'Test DiskANN Search Cancellation'\n- ./build-repro-asan/Release/tests/ut/knowhere_tests '[diskann]' repeated 5 times\n- make BUILD_DIR=/home/fox/Work/code/knowhere/knowhere-repro-actions-26519523126/build-repro-asan test

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@alexanderguzhva
Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexanderguzhva,foxspy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 02556d2 into zilliztech:main May 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants