Skip to content

fix: avoid raw cap for IVF_FLAT_CC ensure topk search#1658

Merged
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:fix/ivf-flat-cc-ensure-topk
May 29, 2026
Merged

fix: avoid raw cap for IVF_FLAT_CC ensure topk search#1658
sre-ci-robot merged 1 commit into
zilliztech:mainfrom
foxspy:fix/ivf-flat-cc-ensure-topk

Conversation

@foxspy
Copy link
Copy Markdown
Collaborator

@foxspy foxspy commented May 29, 2026

issue: #1657

Summary

  • Align IVF_FLAT_CC ensure_topk_full list scanning with IVF baseline behavior.
  • Add a restrictive-bitset regression test to ensure topk can be filled.

Tests

  • pre-commit run --files thirdparty/faiss/faiss/cppcontrib/knowhere/impl/cc_search.cpp tests/ut/test_ivfflat_cc.cc
  • make WITH_UT=True
  • source build/Release/generators/conanrun.sh && ./build/Release/tests/ut/knowhere_tests "Test IVFFLAT_CC ensure topk with restrictive bitset"
  • source build/Release/generators/conanrun.sh && ./build/Release/tests/ut/knowhere_tests "[ivfflat_cc]"

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added the dco-passed label May 29, 2026
@foxspy foxspy added the kind/bug This PR is a bug fix label May 29, 2026
@mergify mergify Bot added the ci-passed label May 29, 2026
@alexanderguzhva
Copy link
Copy Markdown
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 92a3263 into zilliztech:main May 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants