Skip to content

bump milvus-common and cardinalv1 version#1659

Merged
foxspy merged 2 commits into
zilliztech:2.6from
sparknack:milvus-common-update-26
Jun 2, 2026
Merged

bump milvus-common and cardinalv1 version#1659
foxspy merged 2 commits into
zilliztech:2.6from
sparknack:milvus-common-update-26

Conversation

@sparknack

@sparknack sparknack commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

issue: #1660

@sre-ci-robot sre-ci-robot requested review from chasingegg and foxspy May 30, 2026 05:53
@mergify

mergify Bot commented May 30, 2026

Copy link
Copy Markdown

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@sparknack

sparknack commented May 30, 2026

Copy link
Copy Markdown
Collaborator Author

/kind improvement

@mergify

mergify Bot commented May 30, 2026

Copy link
Copy Markdown

@sparknack e2e jenkins job failed, comment /run-e2e can trigger the job again.

1 similar comment
@mergify

mergify Bot commented Jun 1, 2026

Copy link
Copy Markdown

@sparknack e2e jenkins job failed, comment /run-e2e can trigger the job again.

@sparknack
bump milvus-common version
d243899 
Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
@sparknack sparknack force-pushed the milvus-common-update-26 branch from d46183c to eed9263 Compare June 1, 2026 10:12
@mergify

mergify Bot commented Jun 1, 2026

Copy link
Copy Markdown

@sparknack e2e jenkins job failed, comment /run-e2e can trigger the job again.

alexanderguzhva
alexanderguzhva reviewed Jun 1, 2026
View reviewed changes
Comment thread cmake/libs/cardinal/v1/CMakeLists.txt Outdated
# Use short SHA1 as version
# v2.5 tag is used for cardinal v1
set(CARDINAL_VERSION v2.5.104)
set(CARDINAL_VERSION v1-test-ws)

@alexanderguzhva alexanderguzhva Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sparknack is it a test PR?

@sparknack sparknack Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we are waiting for another pr.

@sparknack
bump cardinalv1 version
0551b15 
Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>
@sparknack sparknack force-pushed the milvus-common-update-26 branch from eed9263 to 0551b15 Compare June 2, 2026 03:23
@sparknack sparknack changed the title bump milvus-common version bump milvus-common and cardinalv1 version Jun 2, 2026
zhengbuqian
zhengbuqian approved these changes Jun 2, 2026
View reviewed changes

@zhengbuqian zhengbuqian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

foxspy
foxspy approved these changes Jun 2, 2026
View reviewed changes

@foxspy foxspy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot

sre-ci-robot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, sparknack, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot removed the ci-passed label Jun 2, 2026
@foxspy foxspy merged commit 350fedb into zilliztech:2.6 Jun 2, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexanderguzhva alexanderguzhva alexanderguzhva left review comments
@foxspy foxspy foxspy approved these changes
@zhengbuqian zhengbuqian zhengbuqian approved these changes
@chasingegg chasingegg Awaiting requested review from chasingegg

Assignees

@foxspy foxspy

@zhengbuqian zhengbuqian

Labels

approved dco-passed kind/improvement lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sparknack @sre-ci-robot @alexanderguzhva @foxspy @zhengbuqian