Replace panic!() with proper error handling#341
Open
zurawiki wants to merge 1 commit into
Open
Conversation
Change get_llm_client to return Result instead of panicking on config errors. Users hitting missing API keys or bad config now get a clear error message instead of a stack trace in their git hook. Also fix config key test to be platform-independent — toml serialization of None values differs across platforms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zurawiki
force-pushed
the
fix-error-handling
branch
from
6cc3911 to
6499a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
get_llm_clientusedpanic!()for config errors, producing ugly stack traces inside a git hook instead of clear error messages. Also fixes a pre-existing test failure where config key serialization ofNonevalues differs across platforms.Stack: depends on #340
Test plan
cargo test— all 8 tests pass on all platforms (Linux, macOS, Windows)git commit— verify a clean error message instead of a panic stack trace