some code I added to make OpenApi reader work on my files#26
Open
some code I added to make OpenApi reader work on my files#26
Conversation
Member
|
I don't get what this should fix. The primitive schema should not be visited because it rather considered to be abstract. As for the OALink this covers existing bugs. Can you provide me with the file you want to read instead? |
Contributor
Author
|
So I added a test for each case:
|
Member
|
I don't get why you make extension methods here for JSONSchema. Look at zweidenker/JSONSchema#40 that adds minItems and maxItems. What else needs to be done? |
Member
|
Can remove the minItem and json schema stuff please? |
Contributor
Author
|
Ok, i just
There should now be 2 test failing, which i think highlights 2 issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.