Re-enable rendermdl tests#2834
Re-enable rendermdl tests#2834jreichel-nvidia wants to merge 6 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Render Script Tests", 'Viewer Tests", and "Graph Editor Tests" need a GPU which is not available in CI.
"shell" was missing, but YAML syntax is better anyway.
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
From a high level, my sense is that this change contributes MDL render tests to MaterialX CI for the first time, and it's worth highlighting this in the PR description, rather than framing it as a reenabling of a prevous test.
Overall, this looks good to me, and I've written up a potential simplification of the new CI logic, borrowing from the existing pattern of MATERIALX_RENDER_MSL_ONLY.
| TEST_RENDER_CONFIG="-DMATERIALX_TEST_RENDER=ON" | ||
| if [ "${{ runner.os }}" == "macOS" ]; then | ||
| TEST_RENDER_CONFIG="-DMATERIALX_TEST_RENDER=ON -DMATERIALX_RENDER_MSL_ONLY=ON" | ||
| TEST_RENDER_CONFIG="$TEST_RENDER_CONFIG -DMATERIALX_RENDER_MSL_ONLY=ON" |
There was a problem hiding this comment.
Looking at our existing approach for platform-specific render tests, I'd probably recommend following the existing pattern of MATERIALX_RENDER_MSL_ONLY, which was added by @kwokcb to support render tests in MSL without activating all shading languages.
Taking this approach, we could simplify this new MDL-only render test in GitHub CI with a corresponding MATERIALX_RENDER_MDL_ONLY flag, which would be enabled in our nightly builds.
2 participants
Attempt to re-enable the rendermdl tests for the nightly test runs.