Skip to content

Fix nav issues#257

Merged
Blargian merged 14 commits into
mainfrom
fix-nav-issues
Jun 24, 2026
Merged

Fix nav issues#257
Blargian merged 14 commits into
mainfrom
fix-nav-issues

Conversation

@Blargian

Copy link
Copy Markdown
Member

No description provided.

Blargian and others added 2 commits June 24, 2026 11:44
- Language picker icon: S3 URL had no CORS headers so CSS mask-image
  was blocked. Inline the SVG as a base64 data URL — no external
  request, no CORS needed, works everywhere.

- Quickstart back-link 404: Mintlify autogenerates the 'All quickstarts'
  anchor with a raw /get-started/... path (no /docs basePath). Clicking
  it navigated to the wrong URL in production. Fix the clone's href and
  add a click handler with the correct basePath-aware destination.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…irects

Issue 1 - integrations-fallback.json 404:
  The fetch used /assets/integrations-fallback.json (absolute path), which
  resolves to clickhouse.com/assets/... instead of clickhouse.com/docs/assets/...
  in production. Prepend the /docs basePath when on the subpath deployment.

Issue 2 - RSC prefetch 404s from stale docsLinks:
  The fallback JSON contained old Docusaurus-era URLs for 14 integrations
  (interfaces/cpp, integrations/kafka, integrations/s3, etc.) that no longer
  exist at those paths. Updated to current Mintlify file-path URLs.

  Also added 9 redirects for the same old paths so live CMS data (which
  we cannot update from this repo) also resolves correctly:
    /interfaces/{cpp,csharp,go,javascript,python} → language-clients/
    /integrations/kafka → connectors/data-ingestion/kafka
    /integrations/kafka/cloud/amazon-msk → .../kafka/msk
    /integrations/s3 → .../aws/integrating-s3-with-clickhouse
    /integrations/clickpipes/kafka/create-your-first-... → create-kafka-clickpipe

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@mintlify

mintlify Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
ClickHouse-docs 🟢 Ready View Preview Jun 24, 2026, 11:20 AM

Comment thread _site/customizations/quickstart-back-link.js
Comment thread assets/integrations-fallback.json Outdated
Blargian and others added 2 commits June 24, 2026 13:49
…Explorer

All three components used /images/... absolute paths which resolve to
clickhouse.com/images/... instead of clickhouse.com/docs/images/... in
production. Added assetBase/withBase pattern to each component and applied
to all img src and backgroundImage references.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Comment thread _site/customizations/quickstart-back-link.js
Comment thread _site/redirects.json
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Comment thread snippets/components/SampleDatasetExplorer/SampleDatasetExplorer.jsx Outdated
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Comment thread _site/redirects.json
{
"source": "/integrations/clickpipes/kafka/create-your-first-kafka-clickpipe",
"destination": "/integrations/clickpipes/kafka/create-kafka-clickpipe"
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kafka guide redirect wrong slug

High Severity

The new redirect sends /integrations/clickpipes/kafka/create-your-first-kafka-clickpipe to /integrations/clickpipes/kafka/create-kafka-clickpipe, but the guide’s published slug is still create-your-first-kafka-clickpipe. Bookmarks and fallback links targeting the shorter path may not resolve to the guide.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 497538d. Configure here.

Blargian and others added 4 commits June 24, 2026 14:30
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Remove inner image scale transform (was causing blur artifact during
  tile hover animation)
- Add pointer-events: none to images so Mintlify's click-to-zoom
  handler doesn't fire and clicks pass through to the tile/link

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Hide navbar until both logo (homepage) and CTA have been injected,
then reveal with a short opacity transition to eliminate layout shifts.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- quickstart-back-link.js: include locale segment in dest URL so
  translated quickstart pages link back to the correct locale home;
  fix idempotency check to compare against the rewritten dest href
  instead of the source anchor's original href (prevents clone being
  removed/recreated on every MutationObserver pass)

- integrations-fallback.json: fix 5 ClickPipes object-storage entries
  pointing to non-existent /object-storage/overview; use
  /object-storage/amazon-s3/overview which actually exists

- redirects.json + fallback JSON: fix /integrations/s3 redirect target
  casing from lowercase aws/ to AWS/ to match the actual directory

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Comment thread assets/integrations-fallback.json Outdated
Blargian and others added 2 commits June 24, 2026 15:07
The original files were named with the wrong light/dark suffix.
Renaming the actual files and reverting the code swap keeps the
naming convention consistent with all other dataset images.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- GCS: use google-cloud-storage/overview (dedicated page exists)
- Azure Blob: use azure-blob-storage/overview (dedicated page exists)
- DigitalOcean Spaces: revert to generic /object-storage (no dedicated page)
- Azure Event Hubs: revert to generic /object-storage (CMS categorisation issue)
- Amazon S3: unchanged

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9f3e5a. Configure here.

clone.addEventListener('click', function (e) {
e.preventDefault();
window.location.href = dest;
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back link blocks new tab

Medium Severity

The cloned “All quickstarts” back link always calls preventDefault on click and navigates in the same window, so Ctrl/Cmd+click and similar gestures no longer open the quickstarts home in a new tab even though href is set correctly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a9f3e5a. Configure here.

This file is generated from the CMS — all corrections should be made
there, not here. Redirects in _site/redirects.json handle the old
Docusaurus paths in the meantime.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant