Fix nav issues #257
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,8 +36,14 @@ | |
| src.setAttribute('aria-hidden', 'true'); | ||
| } | ||
|
|
||
| // Build the locale- and basePath-aware destination. | ||
| var base = window.location.pathname.startsWith('/docs') ? '/docs' : ''; | ||
| var localeMatch = window.location.pathname.match(/^(?:\/docs)?\/([a-z]{2}(?:-[A-Z]{2})?)(?:\/|$)/); | ||
| var locale = localeMatch ? '/' + localeMatch[1] : ''; | ||
| var dest = base + locale + '/get-started/quickstarts/home'; | ||
|
|
||
| // Already in place — compare against the rewritten dest, not the source href. | ||
| if (clone && header.contains(clone) && clone.getAttribute('href') === dest) { | ||
| return; | ||
| } | ||
| if (clone) clone.remove(); | ||
|
|
@@ -48,6 +54,13 @@ | |
| clone.style.width = 'fit-content'; | ||
| clone.style.marginBottom = '0.75rem'; | ||
| clone.removeAttribute('aria-hidden'); | ||
|
|
||
| clone.setAttribute('href', dest); | ||
| clone.addEventListener('click', function (e) { | ||
| e.preventDefault(); | ||
| window.location.href = dest; | ||
| }); | ||
|
cursor[bot] marked this conversation as resolved.
There was a problem hiding this comment. Back link blocks new tabMedium Severity The cloned “All quickstarts” back link always calls   Reviewed by Cursor Bugbot for commit a9f3e5a. Configure here. |
||
|
|
||
| header.insertBefore(clone, header.firstChild); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -955,6 +955,10 @@ | |
| "destination": "/integrations/connectors/data-ingestion/etl-tools/airbyte-and-clickhouse", | ||
| "source": "/integrations/airbyte-and-clickhouse" | ||
| }, | ||
| { | ||
| "source": "/integrations/clickpipes/kafka/create-your-first-kafka-clickpipe", | ||
| "destination": "/integrations/clickpipes/kafka/create-kafka-clickpipe" | ||
| }, | ||
|
There was a problem hiding this comment. Kafka guide redirect wrong slugHigh Severity The new redirect sends Additional Locations (1)Reviewed by Cursor Bugbot for commit 497538d. Configure here. |
||
| { | ||
| "destination": "/integrations/clickpipes/object-storage/amazon-s3/get-started", | ||
| "source": "/integrations/clickpipes/object-storage" | ||
|
|
@@ -1151,6 +1155,14 @@ | |
| "destination": "/integrations/language-clients/java/jdbc", | ||
| "source": "/integrations/jdbc" | ||
| }, | ||
| { | ||
| "source": "/integrations/kafka", | ||
| "destination": "/integrations/connectors/data-ingestion/kafka" | ||
| }, | ||
| { | ||
| "source": "/integrations/kafka/cloud/amazon-msk", | ||
| "destination": "/integrations/connectors/data-ingestion/kafka/msk" | ||
| }, | ||
| { | ||
| "destination": "/integrations/connectors/data-ingestion/kafka/confluent/confluent-cloud", | ||
| "source": "/integrations/kafka/cloud/confluent/custom-connector-cloud" | ||
|
|
@@ -1303,6 +1315,10 @@ | |
| "destination": "/reference/engines/table-engines/integrations/embedded-rocksdb", | ||
| "source": "/integrations/rocksdb" | ||
| }, | ||
| { | ||
| "source": "/integrations/s3", | ||
| "destination": "/integrations/connectors/data-ingestion/AWS/integrating-s3-with-clickhouse" | ||
| }, | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| { | ||
| "destination": "/integrations/connectors/data-ingestion/AWS/integrating-s3-with-clickhouse", | ||
| "source": "/integrations/s3/s3-intro" | ||
|
|
@@ -1371,14 +1387,34 @@ | |
| "destination": "/concepts/features/interfaces/overview", | ||
| "source": "/interfaces" | ||
| }, | ||
| { | ||
| "source": "/interfaces/cpp", | ||
| "destination": "/integrations/language-clients/cpp" | ||
| }, | ||
| { | ||
| "source": "/interfaces/csharp", | ||
| "destination": "/integrations/language-clients/csharp/overview" | ||
| }, | ||
| { | ||
| "destination": "/reference/formats/Protobuf/Protobuf", | ||
| "source": "/interfaces/formats/Protobuf/Protobuf" | ||
| }, | ||
| { | ||
| "source": "/interfaces/go", | ||
| "destination": "/integrations/language-clients/go" | ||
| }, | ||
| { | ||
| "destination": "/concepts/features/interfaces/http", | ||
| "source": "/interfaces/http_interface" | ||
| }, | ||
| { | ||
| "source": "/interfaces/javascript", | ||
| "destination": "/integrations/language-clients/js" | ||
| }, | ||
| { | ||
| "source": "/interfaces/python", | ||
| "destination": "/integrations/language-clients/python" | ||
| }, | ||
| { | ||
| "destination": "/integrations/language-clients/third-party/client-libraries", | ||
| "source": "/interfaces/third-party/client_libraries" | ||
|
|
@@ -1815,6 +1851,10 @@ | |
| "destination": "/products/cloud/reference/billing/billing-overview", | ||
| "source": "/pricing" | ||
| }, | ||
| { | ||
| "destination": "/products/cloud/guides/security/cmek", | ||
| "source": "/products/cloud/guides/security/cmek-migration" | ||
| }, | ||
| { | ||
| "destination": "/reference/functions/aggregate-functions", | ||
| "source": "/query_language/agg_functions" | ||
|
|
@@ -2734,9 +2774,5 @@ | |
| { | ||
| "destination": "/resources/changelogs/security-changelog", | ||
| "source": "/whats_new/security_changelog" | ||
| } | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.