Implement configuration error tagging for all backend requests#10963
Implement configuration error tagging for all backend requests#10963daniel-mohedano wants to merge 2 commits intomasterfrom
Conversation
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - netflix-zuulJob Status: success
|
Test Environment - pass4sJob Status: success
|
Test Environment - reactive-streams-jvmJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - sonar-kotlinJob Status: success
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066322
Total [baseline] (11.183 s) : 0, 11182621
Agent [candidate] (1.061 s) : 0, 1061107
Total [candidate] (11.218 s) : 0, 11217732
section appsec
Agent [baseline] (1.257 s) : 0, 1257195
Total [baseline] (11.118 s) : 0, 11118134
Agent [candidate] (1.251 s) : 0, 1250612
Total [candidate] (11.237 s) : 0, 11236804
section iast
Agent [baseline] (1.232 s) : 0, 1231759
Total [baseline] (11.263 s) : 0, 11262696
Agent [candidate] (1.23 s) : 0, 1230252
Total [candidate] (11.402 s) : 0, 11402308
section profiling
Agent [baseline] (1.182 s) : 0, 1182343
Total [baseline] (11.002 s) : 0, 11002123
Agent [candidate] (1.183 s) : 0, 1182909
Total [candidate] (11.017 s) : 0, 11017191
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (634.235 ms) : 0, 634235
BytebuddyAgent [candidate] (629.464 ms) : 0, 629464
AgentMeter [baseline] (29.673 ms) : 0, 29673
AgentMeter [candidate] (29.659 ms) : 0, 29659
GlobalTracer [baseline] (258.955 ms) : 0, 258955
GlobalTracer [candidate] (258.792 ms) : 0, 258792
AppSec [baseline] (31.993 ms) : 0, 31993
AppSec [candidate] (32.041 ms) : 0, 32041
Debugger [baseline] (60.996 ms) : 0, 60996
Debugger [candidate] (60.847 ms) : 0, 60847
Remote Config [baseline] (594.299 µs) : 0, 594
Remote Config [candidate] (598.467 µs) : 0, 598
Telemetry [baseline] (8.884 ms) : 0, 8884
Telemetry [candidate] (8.07 ms) : 0, 8070
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (4.296 ms) : 0, 4296
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (664.708 ms) : 0, 664708
BytebuddyAgent [candidate] (660.796 ms) : 0, 660796
AgentMeter [baseline] (12.214 ms) : 0, 12214
AgentMeter [candidate] (12.115 ms) : 0, 12115
GlobalTracer [baseline] (260.287 ms) : 0, 260287
GlobalTracer [candidate] (258.981 ms) : 0, 258981
AppSec [baseline] (178.645 ms) : 0, 178645
AppSec [candidate] (177.992 ms) : 0, 177992
Debugger [baseline] (66.724 ms) : 0, 66724
Debugger [candidate] (66.393 ms) : 0, 66393
Remote Config [baseline] (616.88 µs) : 0, 617
Remote Config [candidate] (619.783 µs) : 0, 620
Telemetry [baseline] (8.334 ms) : 0, 8334
Telemetry [candidate] (8.43 ms) : 0, 8430
Flare Poller [baseline] (3.551 ms) : 0, 3551
Flare Poller [candidate] (3.55 ms) : 0, 3550
IAST [baseline] (24.399 ms) : 0, 24399
IAST [candidate] (24.22 ms) : 0, 24220
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (799.026 ms) : 0, 799026
BytebuddyAgent [candidate] (798.143 ms) : 0, 798143
AgentMeter [baseline] (11.467 ms) : 0, 11467
AgentMeter [candidate] (11.455 ms) : 0, 11455
GlobalTracer [baseline] (248.147 ms) : 0, 248147
GlobalTracer [candidate] (248.184 ms) : 0, 248184
AppSec [baseline] (26.509 ms) : 0, 26509
AppSec [candidate] (26.503 ms) : 0, 26503
Debugger [baseline] (70.933 ms) : 0, 70933
Debugger [candidate] (70.424 ms) : 0, 70424
Remote Config [baseline] (524.306 µs) : 0, 524
Remote Config [candidate] (525.0 µs) : 0, 525
Telemetry [baseline] (9.164 ms) : 0, 9164
Telemetry [candidate] (9.103 ms) : 0, 9103
Flare Poller [baseline] (3.323 ms) : 0, 3323
Flare Poller [candidate] (3.299 ms) : 0, 3299
IAST [baseline] (25.314 ms) : 0, 25314
IAST [candidate] (25.306 ms) : 0, 25306
section profiling
ProfilingAgent [baseline] (93.761 ms) : 0, 93761
ProfilingAgent [candidate] (93.616 ms) : 0, 93616
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (682.878 ms) : 0, 682878
BytebuddyAgent [candidate] (683.576 ms) : 0, 683576
AgentMeter [baseline] (9.008 ms) : 0, 9008
AgentMeter [candidate] (8.989 ms) : 0, 8989
GlobalTracer [baseline] (214.828 ms) : 0, 214828
GlobalTracer [candidate] (214.84 ms) : 0, 214840
AppSec [baseline] (32.111 ms) : 0, 32111
AppSec [candidate] (32.156 ms) : 0, 32156
Debugger [baseline] (65.188 ms) : 0, 65188
Debugger [candidate] (65.935 ms) : 0, 65935
Remote Config [baseline] (558.32 µs) : 0, 558
Remote Config [candidate] (556.342 µs) : 0, 556
Telemetry [baseline] (8.513 ms) : 0, 8513
Telemetry [candidate] (7.685 ms) : 0, 7685
Flare Poller [baseline] (3.441 ms) : 0, 3441
Flare Poller [candidate] (3.484 ms) : 0, 3484
Profiling [baseline] (94.334 ms) : 0, 94334
Profiling [candidate] (94.171 ms) : 0, 94171
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068956
Total [baseline] (8.916 s) : 0, 8916431
Agent [candidate] (1.06 s) : 0, 1059812
Total [candidate] (8.858 s) : 0, 8857857
section iast
Agent [baseline] (1.227 s) : 0, 1227443
Total [baseline] (9.581 s) : 0, 9581044
Agent [candidate] (1.229 s) : 0, 1229430
Total [candidate] (9.579 s) : 0, 9578839
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (636.908 ms) : 0, 636908
BytebuddyAgent [candidate] (630.052 ms) : 0, 630052
AgentMeter [baseline] (29.917 ms) : 0, 29917
AgentMeter [candidate] (29.554 ms) : 0, 29554
GlobalTracer [baseline] (259.224 ms) : 0, 259224
GlobalTracer [candidate] (257.702 ms) : 0, 257702
AppSec [baseline] (32.13 ms) : 0, 32130
AppSec [candidate] (31.815 ms) : 0, 31815
Debugger [baseline] (60.304 ms) : 0, 60304
Debugger [candidate] (59.71 ms) : 0, 59710
Remote Config [baseline] (599.869 µs) : 0, 600
Remote Config [candidate] (581.669 µs) : 0, 582
Telemetry [baseline] (8.804 ms) : 0, 8804
Telemetry [candidate] (9.547 ms) : 0, 9547
Flare Poller [baseline] (3.556 ms) : 0, 3556
Flare Poller [candidate] (3.525 ms) : 0, 3525
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (796.574 ms) : 0, 796574
BytebuddyAgent [candidate] (797.549 ms) : 0, 797549
AgentMeter [baseline] (11.401 ms) : 0, 11401
AgentMeter [candidate] (11.384 ms) : 0, 11384
GlobalTracer [baseline] (247.209 ms) : 0, 247209
GlobalTracer [candidate] (248.029 ms) : 0, 248029
IAST [baseline] (25.348 ms) : 0, 25348
IAST [candidate] (25.322 ms) : 0, 25322
AppSec [baseline] (26.512 ms) : 0, 26512
AppSec [candidate] (26.544 ms) : 0, 26544
Debugger [baseline] (67.327 ms) : 0, 67327
Debugger [candidate] (68.134 ms) : 0, 68134
Remote Config [baseline] (521.691 µs) : 0, 522
Remote Config [candidate] (525.196 µs) : 0, 525
Telemetry [baseline] (11.267 ms) : 0, 11267
Telemetry [candidate] (10.738 ms) : 0, 10738
Flare Poller [baseline] (3.932 ms) : 0, 3932
Flare Poller [candidate] (3.801 ms) : 0, 3801
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1174, 1197
. : milestone, 1185,
iast (3.286 ms) : 3242, 3331
. : milestone, 3286,
iast_FULL (5.84 ms) : 5782, 5898
. : milestone, 5840,
iast_GLOBAL (3.617 ms) : 3562, 3671
. : milestone, 3617,
profiling (2.048 ms) : 2030, 2066
. : milestone, 2048,
tracing (1.821 ms) : 1804, 1837
. : milestone, 1821,
section candidate
no_agent (1.182 ms) : 1171, 1194
. : milestone, 1182,
iast (3.162 ms) : 3123, 3200
. : milestone, 3162,
iast_FULL (5.664 ms) : 5608, 5720
. : milestone, 5664,
iast_GLOBAL (3.632 ms) : 3565, 3699
. : milestone, 3632,
profiling (2.091 ms) : 2071, 2110
. : milestone, 2091,
tracing (1.794 ms) : 1779, 1810
. : milestone, 1794,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (17.207 ms) : 17039, 17376
. : milestone, 17207,
appsec (18.737 ms) : 18547, 18927
. : milestone, 18737,
code_origins (18.03 ms) : 17854, 18206
. : milestone, 18030,
iast (18.028 ms) : 17848, 18207
. : milestone, 18028,
profiling (18.947 ms) : 18756, 19138
. : milestone, 18947,
tracing (17.658 ms) : 17481, 17834
. : milestone, 17658,
section candidate
no_agent (19.277 ms) : 19083, 19472
. : milestone, 19277,
appsec (18.438 ms) : 18254, 18623
. : milestone, 18438,
code_origins (17.847 ms) : 17673, 18022
. : milestone, 17847,
iast (17.874 ms) : 17697, 18052
. : milestone, 17874,
profiling (18.64 ms) : 18450, 18829
. : milestone, 18640,
tracing (18.611 ms) : 18427, 18796
. : milestone, 18611,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (3.781 ms) : 3559, 4003
. : milestone, 3781,
iast (2.249 ms) : 2180, 2318
. : milestone, 2249,
iast_GLOBAL (2.291 ms) : 2221, 2360
. : milestone, 2291,
profiling (2.141 ms) : 2083, 2200
. : milestone, 2141,
tracing (2.053 ms) : 2000, 2106
. : milestone, 2053,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.798 ms) : 3576, 4019
. : milestone, 3798,
iast (2.242 ms) : 2173, 2311
. : milestone, 2242,
iast_GLOBAL (2.285 ms) : 2215, 2354
. : milestone, 2285,
profiling (2.073 ms) : 2018, 2127
. : milestone, 2073,
tracing (2.057 ms) : 2003, 2110
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~12ea5e4e93, baseline=1.61.0-SNAPSHOT~fd087771cb
dateFormat X
axisFormat %s
section baseline
no_agent (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
appsec (14.709 s) : 14709000, 14709000
. : milestone, 14709000,
iast (18.374 s) : 18374000, 18374000
. : milestone, 18374000,
iast_GLOBAL (18.083 s) : 18083000, 18083000
. : milestone, 18083000,
profiling (15.42 s) : 15420000, 15420000
. : milestone, 15420000,
tracing (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
section candidate
no_agent (15.549 s) : 15549000, 15549000
. : milestone, 15549000,
appsec (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
iast (18.048 s) : 18048000, 18048000
. : milestone, 18048000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
tracing (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
|
Test Environment - okhttpJob Status: success
|
Test Environment - spring_bootJob Status: success
|
Test Environment - sonar-javaJob Status: success
|
| if (configurationError) { | ||
| span.setTag(DDTags.CI_LIBRARY_CONFIGURATION_ERROR, true); | ||
| } | ||
| configurationErrors.applyTags(span); |
| return settings || skippableTests || flakyTests || knownTests || testManagementTests; | ||
| } | ||
|
|
||
| public void applyTags(AgentSpan span) { |
There was a problem hiding this comment.
After this patch, the old tag disappears entirely and only the new per-request tags are emitted. Should it continue setting the old tag so that any legacy tag consumer can still detect an error?
What Does This Do
_dd.ci.library_configuration_errortag with per-request error tags so each backend request failure is tracked individually:_dd.ci.library_configuration_error.settings_dd.ci.library_configuration_error.skippable_tests_dd.ci.library_configuration_error.flaky_tests_dd.ci.library_configuration_error.known_tests_dd.ci.library_configuration_error.test_management_testsMotivation
This will help us surface warnings in the UI when any of our features didn't work as expected due to a failure in our backend.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-3521
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.