-
Notifications
You must be signed in to change notification settings - Fork 330
Implement configuration error tagging for all backend requests #10963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daniel-mohedano
wants to merge
2
commits into
master
Choose a base branch
from
daniel.mohedano/request-failures-tagging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
...nt-ci-visibility/src/main/java/datadog/trace/civisibility/config/ConfigurationErrors.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| package datadog.trace.civisibility.config; | ||
|
|
||
| import datadog.trace.api.DDTags; | ||
| import datadog.trace.bootstrap.instrumentation.api.AgentSpan; | ||
| import datadog.trace.civisibility.ipc.serialization.Serializer; | ||
| import java.nio.ByteBuffer; | ||
| import java.util.Objects; | ||
|
|
||
| /** Tracks which CI Visibility backend requests failed. */ | ||
| public class ConfigurationErrors { | ||
|
|
||
| public static final ConfigurationErrors NONE = | ||
| new ConfigurationErrors(false, false, false, false, false); | ||
|
|
||
| private static final int SETTINGS_FLAG = 1; | ||
| private static final int SKIPPABLE_TESTS_FLAG = 2; | ||
| private static final int FLAKY_TESTS_FLAG = 4; | ||
| private static final int KNOWN_TESTS_FLAG = 8; | ||
| private static final int TEST_MANAGEMENT_TESTS_FLAG = 16; | ||
|
|
||
| private final boolean settings; | ||
| private final boolean skippableTests; | ||
| private final boolean flakyTests; | ||
| private final boolean knownTests; | ||
| private final boolean testManagementTests; | ||
|
|
||
| public ConfigurationErrors( | ||
| boolean settings, | ||
| boolean skippableTests, | ||
| boolean flakyTests, | ||
| boolean knownTests, | ||
| boolean testManagementTests) { | ||
| this.settings = settings; | ||
| this.skippableTests = skippableTests; | ||
| this.flakyTests = flakyTests; | ||
| this.knownTests = knownTests; | ||
| this.testManagementTests = testManagementTests; | ||
| } | ||
|
|
||
| public boolean hasAny() { | ||
| return settings || skippableTests || flakyTests || knownTests || testManagementTests; | ||
| } | ||
|
|
||
| public void applyTags(AgentSpan span) { | ||
| if (settings) { | ||
| span.setTag(DDTags.CI_LIBRARY_CONFIGURATION_ERROR_SETTINGS, true); | ||
| } | ||
| if (skippableTests) { | ||
| span.setTag(DDTags.CI_LIBRARY_CONFIGURATION_ERROR_SKIPPABLE_TESTS, true); | ||
| } | ||
| if (flakyTests) { | ||
| span.setTag(DDTags.CI_LIBRARY_CONFIGURATION_ERROR_FLAKY_TESTS, true); | ||
| } | ||
| if (knownTests) { | ||
| span.setTag(DDTags.CI_LIBRARY_CONFIGURATION_ERROR_KNOWN_TESTS, true); | ||
| } | ||
| if (testManagementTests) { | ||
| span.setTag(DDTags.CI_LIBRARY_CONFIGURATION_ERROR_TEST_MANAGEMENT_TESTS, true); | ||
| } | ||
| } | ||
|
|
||
| public static void serialize(Serializer s, ConfigurationErrors errors) { | ||
| byte flags = | ||
| (byte) | ||
| ((errors.settings ? SETTINGS_FLAG : 0) | ||
| | (errors.skippableTests ? SKIPPABLE_TESTS_FLAG : 0) | ||
| | (errors.flakyTests ? FLAKY_TESTS_FLAG : 0) | ||
| | (errors.knownTests ? KNOWN_TESTS_FLAG : 0) | ||
| | (errors.testManagementTests ? TEST_MANAGEMENT_TESTS_FLAG : 0)); | ||
| s.write(flags); | ||
| } | ||
|
|
||
| public static ConfigurationErrors deserialize(ByteBuffer buffer) { | ||
| byte flags = Serializer.readByte(buffer); | ||
| if (flags == 0) { | ||
| return NONE; | ||
| } | ||
| return new ConfigurationErrors( | ||
| (flags & SETTINGS_FLAG) != 0, | ||
| (flags & SKIPPABLE_TESTS_FLAG) != 0, | ||
| (flags & FLAKY_TESTS_FLAG) != 0, | ||
| (flags & KNOWN_TESTS_FLAG) != 0, | ||
| (flags & TEST_MANAGEMENT_TESTS_FLAG) != 0); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| ConfigurationErrors that = (ConfigurationErrors) o; | ||
| return settings == that.settings | ||
| && skippableTests == that.skippableTests | ||
| && flakyTests == that.flakyTests | ||
| && knownTests == that.knownTests | ||
| && testManagementTests == that.testManagementTests; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(settings, skippableTests, flakyTests, knownTests, testManagementTests); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this patch, the old tag disappears entirely and only the new per-request tags are emitted. Should it continue setting the old tag so that any legacy tag consumer can still detect an error?