[codex] add ArduinoCore LPC8xx board metadata#514
Conversation
|
Warning Review limit reached
More reviews will be available in 31 minutes and 11 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (24)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3ac08e6 to
36f318f
Compare
36f318f to
c85de87
Compare
c85de87 to
5d1120a
Compare
…badges (#536) Add passing no-op CI slots for the two ArduinoCore-LPC8xx variants that do not yet have in-tree fixtures (tests/platform/<variant>/). Board JSONs already landed in #514; conversion to real template_build.yml callers is tracked in #528 (Stage 8 of META #487). The originally drafted lpcxpresso845max stub is intentionally NOT included: PR #514 already shipped the real template_build.yml caller plus fixture and board JSON, and that workflow is green on main. Refs #528, #487 Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Summary
Add the concrete board metadata now available in
zackees/ArduinoCore-LPC8xxfor:This also teaches fbuild to preserve
build.ldscriptandbuild.openocd_target, uses board metadata as the source for package-specific CPU defines, and enables real LPC804/LPC845 CI fixtures instead of the previous no-op workflow stubs.Root Cause
The ArduinoCore-LPC8xx package now exposes board-level details that fbuild previously lacked. fbuild only had generic
lpc804/lpc845entries and hard-coded one LPC845 package CPU ID, so the LPCXpresso845-MAXCPU_LPC845M301JBD64variant could not compile through the NXP LPC8xx Arduino stub.Validation
soldr cargo fmtsoldr cargo test -p fbuild-config test_lpc8xx_arduino_core_board_configs -- --nocapturesoldr cargo test -p fbuild-build board_lpc_family_accepts_concrete_arduino_boards -- --nocapturesoldr cargo test -p fbuild-build nxplpc -- --nocapturesoldr cargo clippy -p fbuild-config --all-targets -- -D warningssoldr cargo clippy -p fbuild-build --all-targets -- -D warningssoldr cargo build -p fbuild-cli -p fbuild-daemontarget\x86_64-pc-windows-msvc\debug\fbuild.exe build tests\platform\lpc804 --quick -v --no-timestamptarget\x86_64-pc-windows-msvc\debug\fbuild.exe build tests\platform\lpc845 --quick -v --no-timestamptarget\x86_64-pc-windows-msvc\debug\fbuild.exe build tests\platform\lpcxpresso845max --quick -v --no-timestampI also checked the LPCXpresso845-MAX compiler response files and confirmed they contain
CPU_LPC845M301JBD64,ARDUINO_LPCXPRESSO845MAX, andARDUINO_ARCH_LPC8XXwithoutCPU_LPC845M301JBD48.