Skip to content

Conversation

@galaxys10pluss
Copy link

Added RunConfig interface definition to README.

Added RunConfig interface definition to README.
@google-cla
Copy link

google-cla bot commented Dec 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link

Summary of Changes

Hello @galaxys10pluss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's documentation by formally defining the RunConfig interface within the README.md file. This addition provides clearer guidance on the available configuration parameters for running applications, making it easier for developers to understand and utilize these settings.

Highlights

  • Documentation Update: The README.md file has been updated to include the detailed definition of the RunConfig interface. This interface specifies configuration options such as runCommand, environmentVariables, concurrency, cpu, memoryMiB, minInstances, and maxInstances.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add documentation for the RunConfig interface to the README.md file. However, the added content appears to be misplaced and incorrectly formatted, which disrupts the rendering of the document's main title. Additionally, this interface is already documented within the same file. My review includes a comment suggesting the removal of this redundant and malformed block to correct the formatting and structure of the README.

Comment on lines +1 to +9
interface RunConfig {
runCommand: string;
environmentVariables?: EnvVarConfig[];
concurrency?: number;
cpu?: number;
memoryMiB?: number;
minInstances?: number;
maxInstances?: number;
}# App Hosting adapters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This added block appears to be a mistake. It duplicates the RunConfig interface definition, which is already documented further down in this file under the ### RunConfig section. Additionally, the content is not wrapped in a markdown code block and the closing brace is on the same line as the main document title, which will cause formatting issues. This block should be removed to avoid duplication and fix the document's rendering.

Suggested change
interface RunConfig {
runCommand: string;
environmentVariables?: EnvVarConfig[];
concurrency?: number;
cpu?: number;
memoryMiB?: number;
minInstances?: number;
maxInstances?: number;
}# App Hosting adapters
# App Hosting adapters

sbasiramiri-blip pushed a commit to sbasiramiri-blip/firebase-framework-tools that referenced this pull request Dec 13, 2025
…ended#454)

* fix: use ENTRYPOINT and CMD for proper argument handling

- Change from CMD to ENTRYPOINT + CMD pattern for better Docker practices
- ENTRYPOINT sets the executable that always runs
- CMD provides default arguments that can be overridden
- This allows container runtimes to properly append additional arguments
- Fixes issues with argument passing in container orchestration tools

Before: CMD ["./github-mcp-server", "stdio"]
After: ENTRYPOINT ["./github-mcp-server"] + CMD ["stdio"]

* address review feedback: use absolute path and improve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant