Skip to content

Document RunConfig interface in README #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
galaxys10pluss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document RunConfig interface in README #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# App Hosting adapters
interface RunConfig {
runCommand: string;
environmentVariables?: EnvVarConfig[];
concurrency?: number;
cpu?: number;
memoryMiB?: number;
minInstances?: number;
maxInstances?: number;
}# App Hosting adapters
Comment on lines +1 to +9
Copy link

@gemini-code-assist gemini-code-assist bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This added block appears to be a mistake. It duplicates the RunConfig interface definition, which is already documented further down in this file under the ### RunConfig section. Additionally, the content is not wrapped in a markdown code block and the closing brace is on the same line as the main document title, which will cause formatting issues. This block should be removed to avoid duplication and fix the document's rendering.

Suggested change
interface RunConfig {
runCommand: string;
environmentVariables?: EnvVarConfig[];
concurrency?: number;
cpu?: number;
memoryMiB?: number;
minInstances?: number;
maxInstances?: number;
}# App Hosting adapters
# App Hosting adapters


## Overview

Expand Down