chore: Add different baseline files#490
Open
tevincent wants to merge 5 commits into
Open
Conversation
|
# Conflicts: # build.gradle.kts
tevincent
force-pushed
the
baseline-ktlint
branch
from
e666334 to
6502616
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a set of ktlint baseline.xml files intended to baseline (suppress) existing formatting/style violations across multiple modules in the android-core multi-module library.
Changes:
- Added per-module
config/ktlint/baseline.xmlfiles listing current ktlint violations to be baselined. - Added a root
config/ktlint/baseline.xmlplaceholder baseline file. - Added additional baseline files under new top-level directories (
Compose/,kSuite/) and underLegacy/*/, intended to baseline those areas.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| Thumbnails/config/ktlint/baseline.xml | Adds ktlint baseline entries for Thumbnails sources. |
| Sentry/config/ktlint/baseline.xml | Adds ktlint baseline entries for Sentry main + test sources. |
| RecyclerView/config/ktlint/baseline.xml | Adds ktlint baseline entries for RecyclerView sources. |
| Onboarding/config/ktlint/baseline.xml | Adds ktlint baseline entries for Onboarding sources. |
| Network/Models/config/ktlint/baseline.xml | Adds ktlint baseline entries for Network Models sources. |
| Network/config/ktlint/baseline.xml | Adds ktlint baseline entries for Network sources. |
| Matomo/config/ktlint/baseline.xml | Adds ktlint baseline entries for Matomo sources. |
| Legacy/Stores/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for “Legacy Stores” code paths. |
| Legacy/config/ktlint/baseline.xml | Adds ktlint baseline entries for Legacy module sources. |
| Legacy/Confetti/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for “Legacy Confetti” code paths. |
| Legacy/BugTracker/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for “Legacy BugTracker” code paths. |
| Legacy/AppLock/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for “Legacy AppLock” code paths. |
| Ktor/config/ktlint/baseline.xml | Adds ktlint baseline entries for Ktor sources. |
| kSuite/MykSuite/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for MyKSuite sources (currently under kSuite/). |
| kSuite/kSuitePro/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for KSuitePro (currently under kSuite/). |
| kSuite/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for KSuite (currently under kSuite/). |
| FragmentNavigation/config/ktlint/baseline.xml | Adds ktlint baseline entries for FragmentNavigation sources. |
| CrossAppLogin/Front/config/ktlint/baseline.xml | Adds ktlint baseline entries for CrossAppLogin Front sources. |
| CrossAppLogin/config/ktlint/baseline.xml | Adds ktlint baseline entries for CrossAppLogin root module build script. |
| CrossAppLogin/Back/config/ktlint/baseline.xml | Adds ktlint baseline entries for CrossAppLogin Back sources. |
| config/ktlint/baseline.xml | Adds a root ktlint baseline placeholder file. |
| Compose/MaterialThemeFromXml/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for MaterialThemeFromXml (currently under Compose/). |
| Compose/Margin/config/ktlint/baseline.xml | Adds an (empty) ktlint baseline file intended for Margin (currently under Compose/). |
| Compose/config/ktlint/baseline.xml | Adds an (empty) ktlint baseline file under top-level Compose/. |
| Compose/Basics/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for Basics (currently under Compose/). |
| Compose/BasicButton/config/ktlint/baseline.xml | Adds ktlint baseline entries intended for BasicButton (currently under Compose/). |
| Coil/config/ktlint/baseline.xml | Adds ktlint baseline entries for Coil sources. |
| Avatar/config/ktlint/baseline.xml | Adds ktlint baseline entries for Avatar sources. |
| Auth/config/ktlint/baseline.xml | Adds ktlint baseline entries for Auth sources and build script. |
| AppIntegrity/config/ktlint/baseline.xml | Adds ktlint baseline entries for AppIntegrity sources and tests. |
tevincent
force-pushed
the
baseline-ktlint
branch
from
e55272a to
3eff0fe
Compare
tevincent
force-pushed
the
baseline-ktlint
branch
from
3eff0fe to
9d35e56
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.