fix(diagnostics): unify panel/export trust and session-scoped reads#7
Draft
KitsuneKode wants to merge 9 commits into
Draft
fix(diagnostics): unify panel/export trust and session-scoped reads#7KitsuneKode wants to merge 9 commits into
KitsuneKode wants to merge 9 commits into
Conversation
…assets GitHub resolves local composite actions from the workspace before any step runs, so nesting checkout inside setup-bun-monorepo made every CI/release/ build-binaries job fail instantly since that action landed. Callers now checkout first; the composite only sets up Bun/caches/install. Also: native smoke matrix for host binaries, fail_on_unmatched_files + asset-count assert on release upload, clearer empty-release installer errors, and fix install.ps1 returning early after mpv so yt-dlp is offered. Co-authored-by: Manash Pratim Bhuyan <bhuyanmanash2002@gmail.com>
v0.2.6.json has an empty sections array (changelog body has no ### headings). The docs test required sections and failed once CI actually ran again after the checkout fix. Co-authored-by: Manash Pratim Bhuyan <bhuyanmanash2002@gmail.com>
cursor
Bot
force-pushed
the
cursor/diagnostics-trust-and-usability-ad11
branch
from
July 9, 2026 20:52
991de13 to
ffcd579
Compare
These failures only surfaced once CI started executing the full suite again (#8). Fix the durable diagnostics retention time bomb, make install.ps1 dry-run succeed without LOCALAPPDATA/network, stop mock.module leaking from palette tests into history/overlay tests, and gate live Miruro network checks.
2 tasks
cursor
Bot
force-pushed
the
cursor/diagnostics-trust-and-usability-ad11
branch
from
July 9, 2026 21:08
ffcd579 to
133f33d
Compare
Typecheck failed because openSetupWizardFromShell was mocked as Promise<void> instead of Promise<SetupWizardResult>, which also broke Format (turbo depends on typecheck for fmt:check).
…rship Make the deprecated preferred-source unit test mock network instead of live fetch, and harden Videasy so deprecated preferred ids never bias cycle order or probe Sanji/1movies. Document that resolveEscTransition stays unused at runtime because root-overlay-shell + resolveOverlayBackStack already own Esc.
Replace mock.module in watch-genre-stats with a restored spy so later tmdb-proxy/title-detail/recommendation tests see the real module, and use relative timestamps in stats-service so windowed averages stay valid.
cursor
Bot
force-pushed
the
cursor/diagnostics-trust-and-usability-ad11
branch
from
July 9, 2026 21:15
133f33d to
5df206f
Compare
Root causes of flaky/hard-to-debug diagnostics after the observability push: dual /diagnostics UIs (list-picker vs overlay), export insight missing panel inputs, durable global recent masking live memory, and correlation latching onto bare session IDs. - Route workflow diagnostics through the same root overlay as the palette - Share panel inputs into support-bundle export/report - Merge session-scoped durable + memory reads; fall back when sink failed - Prefer playback-cycle correlation; implement timeout attempt scanning - Enrich GitHub issue drafts with triage/correlation; fix stale durable test date
cursor
Bot
force-pushed
the
cursor/diagnostics-trust-and-usability-ad11
branch
from
July 9, 2026 21:18
5df206f to
389335b
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the diagnostics/observability push, troubleshooting felt flaky:
/diagnosticsUIs — palette opened the scrollable overlay; workflow/title-control used a list-picker where every line was a selectable row.sessionIdfrom memory samples).Fix
openRootOwnedOverlay(same as palette)buildSupportBundleInputFromContainerso export/report match panel insightCI note
Rebased onto #8. Earlier red X’s were the shared checkout/composite-action infra break, not diagnostics logic.
Tests
diagnostics-trust.test.ts(new)diagnostics-service.test.ts/diagnostics-insight.test.ts