Merged
Conversation
salimtb
changed the base branch from
main
to
feat/assets-controller-pipeline-batching-optimization
salimtb
force-pushed
the
feat/improve-rpc-data-source
branch
from
209e095 to
c5f25f9
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
salimtb
force-pushed
the
feat/improve-rpc-data-source
branch
from
e3cddf0 to
212d43f
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Base automatically changed from
feat/assets-controller-pipeline-batching-optimization
to
main
April 7, 2026 10:27
…ient for token detection
- TokenDetector now fetches token lists directly from the Tokens API
(/v3/chains/{chain}/assets) via TokensApiClient instead of reading
from TokenListController:getState
- Remove TokenDetectorMessenger type; constructor now takes TokensApiClient
as second argument
- RpcDataSource creates a TokensApiClient instance and passes it to
TokenDetector; removes the tokenDetectorMessenger adapter
- Remove #getTokenMetadataFromTokenList from RpcDataSource — unknown
ERC-20 metadata is omitted until TokenDataSource enriches it downstream
- Remove GetTokenListState from RpcDataSourceAllowedActions and
AssetsControllerAllowedActions; TokenListController:getState is no
longer called anywhere in RpcDataSource
- Update all tests to mock TokensApiClient instead of messenger state
salimtb
force-pushed
the
feat/improve-rpc-data-source
branch
from
212d43f to
2de4fb1
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/assets-controller/src/data-sources/evm-rpc-services/services/TokenDetector.ts
Show resolved
Hide resolved
packages/assets-controller/src/data-sources/evm-rpc-services/services/TokenDetector.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 06272c1. Configure here.
packages/assets-controller/src/data-sources/evm-rpc-services/clients/TokensApiClient.ts
Show resolved
Hide resolved
salimtb
commented
Apr 7, 2026
| const TOKENS_API_BASE_URL = 'https://tokens.api.cx.metamask.io/v3/chains'; | ||
|
|
||
| /** How many tokens to request from the API per chain. */ | ||
| const TOKENS_API_FIRST = 25; |
Contributor
Author
There was a problem hiding this comment.
we now auto-detect only the top 25 assets when using the RPC fetcher, which significantly reduces latency in the RPC token detection process.
bergarces
reviewed
Apr 7, 2026
salimtb
commented
Apr 7, 2026
| TokenDetectionOptions, | ||
| TokenDetectionResult, | ||
| TokenListEntry, | ||
| TokenListState, |
Contributor
Author
There was a problem hiding this comment.
TokenList has been replaced by 1 single time fecth to token api top assets
bergarces
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes token detection and RPC metadata behavior by replacing
TokenListController:getStatewith live Tokens API fetches (with caching/fallback), which can affect detected tokens and metadata availability when the API is slow or unavailable.Overview
Token detection now pulls its token list from the Tokens API instead of
TokenListController.TokenDetectortakes a newTokensApiClient, fetches/v3/chains/{chain}/assets, caches results per chain, and falls back to stale cache on API errors (logging failures).RpcDataSourceandAssetsControllerdropTokenListController:getStatefrom allowed actions and remove token-list-based ERC-20 metadata fallbacks; unknown ERC-20s are omitted fromassetsInfountil downstream enrichment. Tests/fixtures are updated accordingly, and a newTokensApiClient(plus unit tests) is added and exported.Reviewed by Cursor Bugbot for commit 9baa7da. Bugbot is set up for automated code reviews on this repo. Configure here.