feat: improve rpc data source

eslint-suppressions.json

@@ -174,9 +174,6 @@
     }
   },
   "packages/assets-controller/src/__fixtures__/MockAssetControllerMessenger.ts": {
-    "import-x/no-relative-packages": {
-      "count": 1
-    },
     "no-restricted-syntax": {
       "count": 4
     }
@@ -188,7 +185,7 @@
   },
   "packages/assets-controller/src/data-sources/RpcDataSource.ts": {
     "no-restricted-syntax": {
-      "count": 3
+      "count": 2
     }
   },
   "packages/assets-controller/src/data-sources/SnapDataSource.ts": {

packages/assets-controller/CHANGELOG.md

@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- `TokenDetector` now fetches the token list directly from the Tokens API (`/v3/chains/{chain}/assets`) via a new `TokensApiClient` instead of reading from `TokenListController:getState` ([#8385](https://github.com/MetaMask/core/pull/8385))
+  - `TokenDetectorMessenger` type has been removed; `TokenDetector` constructor now takes a `TokensApiClient` instance as its second argument
+  - `RpcDataSource` no longer requires `TokenListController:getState` — `GetTokenListState` has been removed from `RpcDataSourceAllowedActions` and `AssetsControllerAllowedActions`
+  - Unknown ERC-20 metadata is no longer looked up from the token list as a fallback in `RpcDataSource`; `TokenDataSource` handles enrichment downstream
 - Split `getAssets` fetch pipeline into a fast awaited path and a parallel fire-and-forget background path to reduce perceived latency on unlock and onboarding ([#8383](https://github.com/MetaMask/core/pull/8383))
   - Fast pipeline: AccountsApi + StakedBalance → Detection → Token + Price (awaited, committed to state immediately)
   - Background pipeline: Snap + RPC run in parallel → Detection → Token + Price when basic functionality is enabled; when disabled (RPC-only mode), Token + Price are omitted (fire-and-forget merge)

packages/assets-controller/src/AssetsController.test.ts

@@ -178,13 +178,6 @@ async function withController<ReturnValue>(
   ).registerActionHandler('NetworkController:getNetworkClientById', () => ({
     provider: {},
   }));
-  (
-    messenger as {
-      registerActionHandler: (a: string, h: () => unknown) => void;
-    }
-  ).registerActionHandler('TokenListController:getState', () => ({
-    tokensChainsCache: {},
-  }));
 
   if (clientControllerState !== undefined) {
     (
@@ -292,13 +285,6 @@ describe('AssetsController', () => {
       ).registerActionHandler('NetworkController:getNetworkClientById', () => ({
         provider: {},
       }));
-      (
-        messenger as {
-          registerActionHandler: (a: string, h: () => unknown) => void;
-        }
-      ).registerActionHandler('TokenListController:getState', () => ({
-        tokensChainsCache: {},
-      }));
 
       const controller = new AssetsController({
         messenger: messenger as unknown as AssetsControllerMessenger,
@@ -393,13 +379,6 @@ describe('AssetsController', () => {
       ).registerActionHandler('NetworkController:getNetworkClientById', () => ({
         provider: {},
       }));
-      (
-        messenger as {
-          registerActionHandler: (a: string, h: () => unknown) => void;
-        }
-      ).registerActionHandler('TokenListController:getState', () => ({
-        tokensChainsCache: {},
-      }));
 
       expect(
         () =>

packages/assets-controller/src/AssetsController.ts

@@ -2,7 +2,6 @@ import type {
   AccountTreeControllerGetAccountsFromSelectedAccountGroupAction,
   AccountTreeControllerSelectedAccountGroupChangeEvent,
 } from '@metamask/account-tree-controller';
-import type { GetTokenListState } from '@metamask/assets-controllers';
 import { BaseController } from '@metamask/base-controller';
 import type {
   ControllerGetStateAction,
@@ -267,7 +266,6 @@ type AllowedActions =
   // AssetsController
   | AccountTreeControllerGetAccountsFromSelectedAccountGroupAction
   // RpcDataSource
-  | GetTokenListState
   | NetworkControllerGetStateAction
   | NetworkControllerGetNetworkClientByIdAction
   // RpcDataSource, StakedBalanceDataSource

packages/assets-controller/src/__fixtures__/MockAssetControllerMessenger.ts

@@ -8,12 +8,12 @@ import {
   MockAnyNamespace,
 } from '@metamask/messenger';
 import { NetworkStatus } from '@metamask/network-controller';
-
 import {
   NetworkState,
   RpcEndpoint,
   RpcEndpointType,
-} from '../../../network-controller/src/NetworkController';
+} from '@metamask/network-controller/src/NetworkController';
+
 import {
   AssetsControllerMessenger,
   getDefaultAssetsControllerState,
@@ -53,7 +53,6 @@ export function createMockAssetControllerMessenger(): {
       'AccountTreeController:getAccountsFromSelectedAccountGroup',
       'AssetsController:getState',
       // RpcDataSource
-      'TokenListController:getState',
       'NetworkController:getState',
       'NetworkController:getNetworkClientById',
       // RpcDataSource, StakedBalanceDataSource
@@ -173,10 +172,6 @@ export function registerRpcDataSourceActions(
     getDefaultAssetsControllerState(),
   );
 
-  rootMessenger.registerActionHandler('TokenListController:getState', () => ({
-    tokensChainsCache: {},
-  }));
-
   rootMessenger.registerActionHandler(
     'NetworkEnablementController:getState',
     () => ({