Pipeline tests for labels#755
Draft
gaurav wants to merge 2 commits into
Draft
Conversation
…sertions Extracts compute_disease_cliques() out of diseasephenotype.build_compendium() so the production glom step and a development-time test simulation share one implementation. Adds two new check types (CliqueCheck, LabelCheck) on top of the existing ID-presence / direct-xref checks, letting developers verify that a candidate label-selection or clique-merge fix will hold up before paying for a full ~500 GB Snakemake build. Seeds the LabelCheck table with the three known regressions (MONDO:0011479 #714, HP:0001508 #711, MONDO:0005578 #723) and one CliqueCheck (MONDO:0011479 -- UMLS:C2930833 #714). The same tables are shaped to be re-parametrized against a real Disease.txt output once an --until disease pipeline fixture is added later. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Records two non-obvious project conventions surfaced while building the disease pipeline checks: concord file basenames are used as lookup keys by compendium builders (so names must match vocabularies exactly), and clique-formation and label-selection are extracted as pure functions so production and dev-time regression checks share one implementation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP