Skip to content

Restore CI and RuboCop linting#41

Merged
NullVoxPopuli merged 1 commit into
NullVoxPopuli:masterfrom
StantonMatt:fix-ci-lint-infra
Jun 2, 2026
Merged

Restore CI and RuboCop linting#41
NullVoxPopuli merged 1 commit into
NullVoxPopuli:masterfrom
StantonMatt:fix-ci-lint-infra

Conversation

@StantonMatt

Copy link
Copy Markdown
Contributor

Summary

  • add GitHub Actions CI for RSpec across the advertised Ruby 2.3-2.7 support range
  • keep ruby-head in the test matrix as an allowed failure, matching the old Travis intent
  • add a RuboCop job, update obsolete RuboCop cop names/options, and baseline existing lint debt in .rubocop_todo.yml

Notes

This follows up on the maintainer request in #40 to help update the CI/lint infra. I kept the PR scoped to infrastructure only; no runtime code changed.

I left Ruby 3.x expansion for a separate support-policy change. This PR mirrors the gemspec's current >= 2.3 support and the existing Travis-era range rather than raising the Ruby floor.

Verification

  • ruby -ryaml -e 'YAML.load_file(".github/workflows/ci.yml"); puts "yaml ok"'
  • bundle exec rspec
  • bundle exec rubocop
  • git diff --check
  • review-fix-loop: clean, no actionable correctness issues

Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NullVoxPopuli NullVoxPopuli left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ttyty

@NullVoxPopuli NullVoxPopuli merged commit 58a5a28 into NullVoxPopuli:master Jun 2, 2026
1 check passed
@StantonMatt

Copy link
Copy Markdown
Contributor Author

Follow-up on the post-merge check display: the merged commit has a visible red Test Ruby head check because continue-on-error still leaves the individual matrix job red in the commit UI, even though the workflow conclusion is success.

I opened #42 to remove only that unsupported Ruby head matrix entry. I rechecked it just now: Ruby 2.3, 2.4, 2.5, 2.6, 2.7, RuboCop, and WIP are all green, and the PR is clean/mergeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants