Restore CI and RuboCop linting#41
Merged
Merged
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
|
|
This was referenced Jun 2, 2026
Contributor
Author
|
Follow-up on the post-merge check display: the merged commit has a visible red I opened #42 to remove only that unsupported Ruby head matrix entry. I rechecked it just now: Ruby 2.3, 2.4, 2.5, 2.6, 2.7, RuboCop, and WIP are all green, and the PR is clean/mergeable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruby-headin the test matrix as an allowed failure, matching the old Travis intent.rubocop_todo.ymlNotes
This follows up on the maintainer request in #40 to help update the CI/lint infra. I kept the PR scoped to infrastructure only; no runtime code changed.
I left Ruby 3.x expansion for a separate support-policy change. This PR mirrors the gemspec's current
>= 2.3support and the existing Travis-era range rather than raising the Ruby floor.Verification
ruby -ryaml -e 'YAML.load_file(".github/workflows/ci.yml"); puts "yaml ok"'bundle exec rspecbundle exec rubocopgit diff --checkreview-fix-loop: clean, no actionable correctness issues