fix(person-follow): fix session leak, tracking spam, and double hook on startup#2407
Open
Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Open
fix(person-follow): fix session leak, tracking spam, and double hook on startup#2407Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Wanbogang wants to merge 3 commits intoOpenMind:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1592
Bug 1 & 2 invalid
Fixes 3 bugs found in person_follow mode affecting stability and LLM token usage.
Changes
Bug 3 — Duplicate lifecycle hook on startup
start_person_follow_hookfromon_startupinconfig/unitree_go2_modes.json5on_entrymode_memory_enabledrestores person_follow state on bootBug 4 — aiohttp.ClientSession created on every poll
_sessioninstance variable to reuse a singleClientSessionacross all poll cyclesBug 5 — TRACKING status messages spammed to LLM
_last_tracking_reportthrottle — TRACKING updates sent at most every 10 seconds